diff options
| author | John Barbero <git@lsrkttn.com> | 2023-11-12 06:30:31 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-11-11 22:30:31 -0700 |
| commit | c2326c05c0778025adc681b962a04626ea6dba77 (patch) | |
| tree | fffc55abcb08873955f207341489f254b229e99e /keyboards/snes_macropad/keymaps/jbarberu | |
| parent | 0189c485b928f26a5835c7c78fdb397494a9d974 (diff) | |
[Keyboard] Fixes to make snes_macropad play nicer with qmk configurator (#22432)
* [Keyboard] Change default implementation for get_layer_name_user
Will now show the layer number instead of "Unknown", since this is
what will be shown if QMK Configurator is used to compile the
firmware.
* [Keyboard] Update the layout info
This makes it look sort of like a macropad + gamepad rather than an 4x6
ortholinear keyboard.
* [Keyboard] Fix default implementation of get_layer_name_user
Based on feedback from code review the implementation was swapped in
favor of using get_u8_str. This implied a change to the argument type
from int to uint8_t, which cascaded into the existing keymaps. (This
made sense in general, since the return type of get_highest_layer is
also a uint8_t.)
Diffstat (limited to 'keyboards/snes_macropad/keymaps/jbarberu')
| -rw-r--r-- | keyboards/snes_macropad/keymaps/jbarberu/keymap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/keyboards/snes_macropad/keymaps/jbarberu/keymap.c b/keyboards/snes_macropad/keymaps/jbarberu/keymap.c index 0fbe0fa626..478d1461e2 100644 --- a/keyboards/snes_macropad/keymaps/jbarberu/keymap.c +++ b/keyboards/snes_macropad/keymaps/jbarberu/keymap.c @@ -81,7 +81,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { }; // clang-format on -const char * get_layer_name_user(int layer) { +const char * get_layer_name_user(uint8_t layer) { switch (layer) { case L_Numpad: return "Numpad"; |