diff options
| author | Joel Challis <git@zvecr.com> | 2022-12-09 01:42:22 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-09 01:42:22 +0000 |
| commit | 99cd0b13e109bb14f1e5af023c5fcb5e50a78e0a (patch) | |
| tree | f6b3198bca1321fb9f4b8c0903d87869a8816630 /keyboards/kinesis/alvicstep | |
| parent | ba6ee2904066aa64fa83417dc865f24dc76d991b (diff) | |
Refactor some led_set_kb instances (#19179)
* Refactor some led_set_kb instances
* Apply suggestions from code review
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'keyboards/kinesis/alvicstep')
| -rw-r--r-- | keyboards/kinesis/alvicstep/alvicstep.c | 27 |
1 files changed, 14 insertions, 13 deletions
diff --git a/keyboards/kinesis/alvicstep/alvicstep.c b/keyboards/kinesis/alvicstep/alvicstep.c index 735032d6a4..a2a62df36a 100644 --- a/keyboards/kinesis/alvicstep/alvicstep.c +++ b/keyboards/kinesis/alvicstep/alvicstep.c @@ -70,19 +70,20 @@ void blink_all_leds(void) matrix_init_user(); } -void led_set_kb(uint8_t usb_led) { - // put your keyboard LED indicator (ex: Caps Lock LED) toggling code here +bool led_update_kb(led_t led_state) { + bool res = led_update_user(led_state); + if(res) { //Copyright 2014 Warren Janssens <warren.janssens@gmail.com> - uint8_t leds = 0xF0; - if (usb_led & 1 << USB_LED_NUM_LOCK) - leds &= ~0x10; - if (usb_led & 1 << USB_LED_CAPS_LOCK) - leds &= ~0x80; - if (usb_led & 1 << USB_LED_SCROLL_LOCK) - leds &= ~0x20; - PORTD = (PORTD & 0x0F) | leds; - - led_set_user(usb_led); - + uint8_t leds = 0xF0; + if (led_state.num_lock) + leds &= ~0x10; + if (led_state.caps_lock) + leds &= ~0x80; + if (led_state.scroll_lock) + leds &= ~0x20; + PORTD = (PORTD & 0x0F) | leds; + + } + return res; } |