summaryrefslogtreecommitdiff
path: root/keyboards/keychron/q8
diff options
context:
space:
mode:
authorJoel Challis <git@zvecr.com>2024-02-09 06:56:13 +0000
committerGitHub <noreply@github.com>2024-02-09 06:56:13 +0000
commit137938b67afbf35fd34f2e5cbe3c5c6367a1d0cc (patch)
tree9bde863a119f5e8c84840b34c839011d9403cfb6 /keyboards/keychron/q8
parente7b84e1cf6d864b1df41e7a81c576baa9d7ca30a (diff)
Migrate dip switch config to info.json - keychron (#23037)
Diffstat (limited to 'keyboards/keychron/q8')
-rw-r--r--keyboards/keychron/q8/config.h6
-rw-r--r--keyboards/keychron/q8/info.json3
-rw-r--r--keyboards/keychron/q8/q8.c8
3 files changed, 3 insertions, 14 deletions
diff --git a/keyboards/keychron/q8/config.h b/keyboards/keychron/q8/config.h
index 163d3775d9..df9c1a9a30 100644
--- a/keyboards/keychron/q8/config.h
+++ b/keyboards/keychron/q8/config.h
@@ -34,12 +34,6 @@
#define SNLED27351_CURRENT_TUNE \
{ 0xC4, 0xC4, 0x60, 0xC4, 0xC4, 0x60, 0xC4, 0xC4, 0x60, 0xC4, 0xC4, 0x60 }
-/* DIP switch */
-#define DIP_SWITCH_MATRIX_GRID { {4, 4} }
-
-/* Disable DIP switch in matrix data */
-#define MATRIX_MASKED
-
/* Encoder Configuration */
#define ENCODER_DEFAULT_POS 0x3
diff --git a/keyboards/keychron/q8/info.json b/keyboards/keychron/q8/info.json
index 7f98bf537c..4d4677f8af 100644
--- a/keyboards/keychron/q8/info.json
+++ b/keyboards/keychron/q8/info.json
@@ -4,6 +4,9 @@
"maintainer": "lalalademaxiya1",
"bootloader": "stm32-dfu",
"diode_direction": "ROW2COL",
+ "dip_switch": {
+ "matrix_grid": [ [4, 4] ]
+ },
"dynamic_keymap": {
"layer_count": 5
},
diff --git a/keyboards/keychron/q8/q8.c b/keyboards/keychron/q8/q8.c
index a653bdc8b9..c28f992f8e 100644
--- a/keyboards/keychron/q8/q8.c
+++ b/keyboards/keychron/q8/q8.c
@@ -16,14 +16,6 @@
#include "quantum.h"
-const matrix_row_t matrix_mask[] = {
- 0b111111111111111,
- 0b111111111111111,
- 0b111111111111111,
- 0b111111111111111,
- 0b111111111101111,
-};
-
#ifdef DIP_SWITCH_ENABLE
bool dip_switch_update_kb(uint8_t index, bool active) {