Update Keychron Q2 (#21994)

Co-authored-by: Drashna Jaelre <drashna@live.com>

4 files changed, 78 insertions, 59 deletions

diff --git a/keyboards/keychron/q2/jis/config.h b/keyboards/keychron/q2/jis/config.h
index 2d83933f9a..fa6fc4e91a 100644
--- a/keyboards/keychron/q2/jis/config.h
+++ b/keyboards/keychron/q2/jis/config.h
@@ -17,9 +17,7 @@
 #pragma once
 
 /* RGB Matrix Configuration */
-#define DRIVER_1_LED_TOTAL 35
-#define DRIVER_2_LED_TOTAL 36
-#define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)
+#define RGB_MATRIX_LED_COUNT 71
 
 #define CKLED2001_CURRENT_TUNE { 0xC0, 0xC0, 0x5D, 0xC0, 0xC0, 0x5D, 0xC0, 0xC0, 0x5D, 0xC0, 0xC0, 0x5D }
 
diff --git a/keyboards/keychron/q2/jis/info.json b/keyboards/keychron/q2/jis/info.json
index d0af24b29d..834b89332e 100644
--- a/keyboards/keychron/q2/jis/info.json
+++ b/keyboards/keychron/q2/jis/info.json
@@ -1,23 +1,86 @@
 {
-    "keyboard_name": "Keychron Q2",
-    "manufacturer": "Keychron",
-    "url": "https://github.com/Keychron",
-    "maintainer": "lalalademaxiya1",
     "usb": {
-        "vid": "0x3434",
         "pid": "0x0114",
         "device_version": "1.0.0"
     },
     "rgb_matrix": {
-        "driver": "ckled2001"
-    },
-    "matrix_pins": {
-        "cols": ["C14", "C15", "A0", "A1", "A2", "A3", "A4", "A5", "A6", "A7", "B0", "B1", "A8", "A9", "H3"],
-        "rows": ["B4", "B3", "A15", "A14", "A13"]
+        "layout": [
+            {"matrix": [0, 0], "x": 0, "y": 4, "flags": 1}, 
+            {"matrix": [0, 1], "x": 15, "y": 4, "flags": 4}, 
+            {"matrix": [0, 2], "x": 29, "y": 4, "flags": 4}, 
+            {"matrix": [0, 3], "x": 44, "y": 4, "flags": 4}, 
+            {"matrix": [0, 4], "x": 59, "y": 4, "flags": 4}, 
+            {"matrix": [0, 5], "x": 73, "y": 4, "flags": 4}, 
+            {"matrix": [0, 6], "x": 88, "y": 4, "flags": 4}, 
+            {"matrix": [0, 7], "x": 103, "y": 4, "flags": 4}, 
+            {"matrix": [0, 8], "x": 117, "y": 4, "flags": 4}, 
+            {"matrix": [0, 9], "x": 132, "y": 4, "flags": 4}, 
+            {"matrix": [0, 10], "x": 146, "y": 4, "flags": 4}, 
+            {"matrix": [0, 11], "x": 161, "y": 4, "flags": 4}, 
+            {"matrix": [0, 12], "x": 176, "y": 4, "flags": 4}, 
+            {"matrix": [0, 13], "x": 190, "y": 4, "flags": 4}, 
+            {"matrix": [3, 1], "x": 205, "y": 4, "flags": 1},
+            {"matrix": [0, 14], "x": 224, "y": 0, "flags": 1},
+
+            {"matrix": [1, 0], "x": 4, "y": 19, "flags": 1},
+            {"matrix": [1, 1], "x": 22, "y": 19, "flags": 4},
+            {"matrix": [1, 2], "x": 37, "y": 19, "flags": 4},
+            {"matrix": [1, 3], "x": 51, "y": 19, "flags": 4},
+            {"matrix": [1, 4], "x": 66, "y": 19, "flags": 4},
+            {"matrix": [1, 5], "x": 81, "y": 19, "flags": 4},
+            {"matrix": [1, 6], "x": 95, "y": 19, "flags": 4},
+            {"matrix": [1, 7], "x": 110, "y": 19, "flags": 4},
+            {"matrix": [1, 8], "x": 125, "y": 19, "flags": 4},
+            {"matrix": [1, 9], "x": 139, "y": 19, "flags": 4},
+            {"matrix": [1, 10], "x": 154, "y": 19, "flags": 4},
+            {"matrix": [1, 11], "x": 168, "y": 19, "flags": 4},
+            {"matrix": [1, 12], "x": 183, "y": 19, "flags": 4},
+            {"matrix": [1, 14], "x": 224, "y": 19, "flags": 1},
+
+            {"matrix": [2, 0], "x": 6, "y": 34, "flags": 1},
+            {"matrix": [2, 1], "x": 26, "y": 34, "flags": 4},
+            {"matrix": [2, 2], "x": 40, "y": 34, "flags": 4},
+            {"matrix": [2, 3], "x": 55, "y": 34, "flags": 4},
+            {"matrix": [2, 4], "x": 70, "y": 34, "flags": 4},
+            {"matrix": [2, 5], "x": 84, "y": 34, "flags": 4},
+            {"matrix": [2, 6], "x": 99, "y": 34, "flags": 4},
+            {"matrix": [2, 7], "x": 114, "y": 34, "flags": 4},
+            {"matrix": [2, 8], "x": 128, "y": 34, "flags": 4},
+            {"matrix": [2, 9], "x": 143, "y": 34, "flags": 4},
+            {"matrix": [2, 10], "x": 158, "y": 34, "flags": 4},
+            {"matrix": [2, 11], "x": 172, "y": 34, "flags": 4},
+            {"matrix": [2, 13], "x": 187, "y": 34, "flags": 4},
+            {"matrix": [1, 13], "x": 207, "y": 29, "flags": 1},
+            {"matrix": [2, 14], "x": 224, "y": 34, "flags": 1},
+
+            {"matrix": [3, 0], "x": 9, "y": 49, "flags": 1},
+            {"matrix": [3, 2], "x": 33, "y": 49, "flags": 4},
+            {"matrix": [3, 3], "x": 48, "y": 49, "flags": 4},
+            {"matrix": [3, 4], "x": 62, "y": 49, "flags": 4},
+            {"matrix": [3, 5], "x": 77, "y": 49, "flags": 4},
+            {"matrix": [3, 6], "x": 92, "y": 49, "flags": 4},
+            {"matrix": [3, 7], "x": 106, "y": 49, "flags": 4},
+            {"matrix": [3, 8], "x": 121, "y": 49, "flags": 4},
+            {"matrix": [3, 9], "x": 136, "y": 49, "flags": 4},
+            {"matrix": [3, 10], "x": 150, "y": 49, "flags": 4},
+            {"matrix": [3, 11], "x": 179, "y": 49, "flags": 4},
+            {"matrix": [3, 13], "x": 194, "y": 49, "flags": 1},
+            {"matrix": [3, 14], "x": 209, "y": 49, "flags": 1},
+
+            {"matrix": [4, 0], "x": 2, "y": 64, "flags": 1},
+            {"matrix": [4, 1], "x": 18, "y": 64, "flags": 1},
+            {"matrix": [4, 2], "x": 35, "y": 64, "flags": 1},
+            {"matrix": [4, 3], "x": 51, "y": 64, "flags": 1},
+            {"matrix": [4, 6], "x": 92, "y": 64, "flags": 4},
+            {"matrix": [4, 9], "x": 134, "y": 64, "flags": 1},
+            {"matrix": [4, 10], "x": 150, "y": 64, "flags": 1},
+            {"matrix": [4, 11], "x": 165, "y": 64, "flags": 1},
+            {"matrix": [4, 12], "x": 179, "y": 64, "flags": 1},
+            {"matrix": [4, 13], "x": 194, "y": 64, "flags": 1},
+            {"matrix": [2, 12], "x": 209, "y": 64, "flags": 1},
+            {"matrix": [4, 14], "x": 223, "y": 64, "flags": 1}
+        ]
     },
-    "diode_direction": "ROW2COL",
-    "processor": "STM32L432",
-    "bootloader": "stm32-dfu",
     "layouts": {
         "LAYOUT_jis_71": {
             "layout": [
diff --git a/keyboards/keychron/q2/jis/jis.c b/keyboards/keychron/q2/jis/jis.c
index 31ed1edc58..9d8f439d6f 100644
--- a/keyboards/keychron/q2/jis/jis.c
+++ b/keyboards/keychron/q2/jis/jis.c
@@ -102,33 +102,4 @@ const ckled2001_led PROGMEM g_ckled2001_leds[RGB_MATRIX_LED_COUNT] = {
     {1, F_16,   D_16,   E_16}
 };
 
-#define __ NO_LED
-
-led_config_t g_led_config = {
-    {
-        // Key Matrix to LED Index
-        { 0,  1,  2,  3,  4,  5,  6,  7,  8,  9,  10, 11, 12, 13, 15 },
-        { 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 43, 29 },
-        { 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 69, 42, 44 },
-        { 45, 14, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58 },
-        { 59, 60, 61, 62, __, __, 63, __, __, 64, 65, 66, 67, 68, 70 }
-    },
-    {
-        // LED Index to Physical Position
-        {0,4},  {15,4},  {29,4},  {44,4},  {59,4},  {73,4},  {88,4},  {103,4},  {117,4},  {132,4},  {146,4},  {161,4},  {176,4},  {190,4},  {205,4},  {224,0},
-        {4,19}, {22,19}, {37,19}, {51,19}, {66,19}, {81,19}, {95,19}, {110,19}, {125,19}, {139,19}, {154,19}, {168,19}, {183,19},                     {224,19},
-        {6,34}, {26,34}, {40,34}, {55,34}, {70,34}, {84,34}, {99,34}, {114,34}, {128,34}, {143,34}, {158,34}, {172,34}, {187,34}, {207,29},           {224,34},
-        {9,49},          {33,49}, {48,49}, {62,49}, {77,49}, {92,49}, {106,49}, {121,49}, {136,49}, {150,49}, {165,49}, {179,49}, {194,49}, {209,49},
-        {2,64}, {18,64}, {35,64}, {51,64},                   {92,64},                     {134,64}, {150,64}, {165,64}, {179,64}, {194,64}, {209,64}, {223,64},
-    },
-    {
-        // RGB LED Index to Flag
-        1, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1, 1,
-        1, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,       1,
-        8, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1,    1,
-        1,    4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1, 1,
-        1, 1, 1, 1,       4,       1, 1, 1, 1, 1, 1, 1
-    }
-};
-
 #endif // RGB_MATRIX_ENABLE
diff --git a/keyboards/keychron/q2/jis/rules.mk b/keyboards/keychron/q2/jis/rules.mk
index cf31e094cb..6e7633bfe0 100644
--- a/keyboards/keychron/q2/jis/rules.mk
+++ b/keyboards/keychron/q2/jis/rules.mk
@@ -1,14 +1 @@
-# Build Options
-#   change yes to no to disable
-#
-BOOTMAGIC_ENABLE = yes      # Enable Bootmagic Lite
-MOUSEKEY_ENABLE = yes       # Mouse keys
-EXTRAKEY_ENABLE = yes       # Audio control and System control
-CONSOLE_ENABLE = no         # Console for debug
-COMMAND_ENABLE = no         # Commands for debug and configuration
-NKRO_ENABLE = yes           # Enable USB N-key Rollover
-BACKLIGHT_ENABLE = no       # Enable keyboard backlight functionality
-RGBLIGHT_ENABLE = no        # Enable keyboard RGB underglow
-AUDIO_ENABLE = no           # Audio output
-DIP_SWITCH_ENABLE = yes
-RGB_MATRIX_ENABLE = yes
+# This file intentionally left blank