summaryrefslogtreecommitdiff
path: root/keyboards/jones
diff options
context:
space:
mode:
authorRyan <fauxpark@gmail.com>2023-02-26 09:45:12 +1100
committerGitHub <noreply@github.com>2023-02-26 09:45:12 +1100
commit7e0299117b389b1c7fcdfa2f20891ba2287ea771 (patch)
tree00bb5bb7b3b73a9de365d1839ba7d41240d439f1 /keyboards/jones
parent314f6c1ddba09851b33e4f3b4bd43bdbc55f9628 (diff)
Move encoder config to data driven (#19923)
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/jones')
-rw-r--r--keyboards/jones/v03/config.h5
-rw-r--r--keyboards/jones/v03/info.json6
-rw-r--r--keyboards/jones/v03_1/config.h5
-rw-r--r--keyboards/jones/v03_1/info.json6
-rw-r--r--keyboards/jones/v1/config.h5
-rw-r--r--keyboards/jones/v1/info.json6
-rw-r--r--keyboards/jones/v1/keymaps/via/config.h3
-rw-r--r--keyboards/jones/v1/keymaps/via/keymap.c8
8 files changed, 22 insertions, 22 deletions
diff --git a/keyboards/jones/v03/config.h b/keyboards/jones/v03/config.h
index f04b9cc78e..fc1ae1ff77 100644
--- a/keyboards/jones/v03/config.h
+++ b/keyboards/jones/v03/config.h
@@ -41,11 +41,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// No need to define DIODE_DIRECTION for Jones' custom Round-Robin matrix.
//#define DIODE_DIRECTION COL2ROW
-/* Rotary Encoder */
-#define ENCODERS_PAD_A { F6, B3 }
-#define ENCODERS_PAD_B { F7, B2 }
-#define ENCODER_RESOLUTION 4 //the default & suggested is 4
-
/* Audio */
#ifdef AUDIO_ENABLE
#define AUDIO_PIN C6
diff --git a/keyboards/jones/v03/info.json b/keyboards/jones/v03/info.json
index 996509d504..388c0fb9ef 100644
--- a/keyboards/jones/v03/info.json
+++ b/keyboards/jones/v03/info.json
@@ -8,6 +8,12 @@
"pid": "0x175A",
"device_version": "0.3.0"
},
+ "encoder": {
+ "rotary": [
+ {"pin_a": "F6", "pin_b": "F7"},
+ {"pin_a": "B3", "pin_b": "B2"}
+ ]
+ },
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"layouts": {
diff --git a/keyboards/jones/v03_1/config.h b/keyboards/jones/v03_1/config.h
index b0d12c8155..548b98e675 100644
--- a/keyboards/jones/v03_1/config.h
+++ b/keyboards/jones/v03_1/config.h
@@ -41,11 +41,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// No need to define DIODE_DIRECTION for Jones' custom Round-Robin matrix.
//#define DIODE_DIRECTION COL2ROW
-/* Rotary Encoder */
-#define ENCODERS_PAD_A { F6, B3 }
-#define ENCODERS_PAD_B { F7, B2 }
-#define ENCODER_RESOLUTION 4 //the default & suggested is 4
-
/* Audio */
#ifdef AUDIO_ENABLE
#define AUDIO_PIN C6
diff --git a/keyboards/jones/v03_1/info.json b/keyboards/jones/v03_1/info.json
index 0bde4d3b5b..45e7b8022f 100644
--- a/keyboards/jones/v03_1/info.json
+++ b/keyboards/jones/v03_1/info.json
@@ -8,6 +8,12 @@
"pid": "0x175A",
"device_version": "0.3.1"
},
+ "encoder": {
+ "rotary": [
+ {"pin_a": "F6", "pin_b": "F7"},
+ {"pin_a": "B3", "pin_b": "B2"}
+ ]
+ },
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"layouts": {
diff --git a/keyboards/jones/v1/config.h b/keyboards/jones/v1/config.h
index aa0ceee74b..1936d5d256 100644
--- a/keyboards/jones/v1/config.h
+++ b/keyboards/jones/v1/config.h
@@ -24,11 +24,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define DIODE_DIRECTION COL2ROW
-/* Rotary Encoder */
-#define ENCODERS_PAD_A { F5, D2 }
-#define ENCODERS_PAD_B { F4, D3 }
-#define ENCODER_RESOLUTION 4 //the default & suggested is 4
-
/* Audio */
#ifdef AUDIO_ENABLE
#define AUDIO_PIN C6
diff --git a/keyboards/jones/v1/info.json b/keyboards/jones/v1/info.json
index 8e03e57950..37f0b70087 100644
--- a/keyboards/jones/v1/info.json
+++ b/keyboards/jones/v1/info.json
@@ -8,6 +8,12 @@
"pid": "0x175A",
"device_version": "1.0.0"
},
+ "encoder": {
+ "rotary": [
+ {"pin_a": "F5", "pin_b": "F4"},
+ {"pin_a": "D2", "pin_b": "D3"}
+ ]
+ },
"bootmagic": {
"matrix": [0, 9]
},
diff --git a/keyboards/jones/v1/keymaps/via/config.h b/keyboards/jones/v1/keymaps/via/config.h
index 5d24e1f91a..a66ab80904 100644
--- a/keyboards/jones/v1/keymaps/via/config.h
+++ b/keyboards/jones/v1/keymaps/via/config.h
@@ -24,9 +24,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// when turn knob clockwise or counterclockwise.
// This is handy to assign key codes by VIA.
-// Number of endoder
-#define ENCODERS 2
-
// Mappings of encoder rotation to key position in key matrix.
// First encoder, Left side : k85, k86
// Second encoder, Right side : k95, k96
diff --git a/keyboards/jones/v1/keymaps/via/keymap.c b/keyboards/jones/v1/keymaps/via/keymap.c
index 651f7d12ee..31a182733a 100644
--- a/keyboards/jones/v1/keymaps/via/keymap.c
+++ b/keyboards/jones/v1/keymaps/via/keymap.c
@@ -168,12 +168,12 @@ bool led_update_user(led_t led_state) {
//------------------------------------------------------------------------------
// Rotary Encoder
//------------------------------------------------------------------------------
-static uint8_t encoder_state[ENCODERS] = {0};
-static keypos_t encoder_cw[ENCODERS] = ENCODERS_CW_KEY;
-static keypos_t encoder_ccw[ENCODERS] = ENCODERS_CCW_KEY;
+static uint8_t encoder_state[NUM_ENCODERS] = {0};
+static keypos_t encoder_cw[NUM_ENCODERS] = ENCODERS_CW_KEY;
+static keypos_t encoder_ccw[NUM_ENCODERS] = ENCODERS_CCW_KEY;
void encoder_action_unregister(void) {
- for (int index = 0; index < ENCODERS; ++index) {
+ for (int index = 0; index < NUM_ENCODERS; ++index) {
if (encoder_state[index]) {
keyevent_t encoder_event = (keyevent_t) {
.key = encoder_state[index] >> 1 ? encoder_cw[index] : encoder_ccw[index],