diff options
| author | QMK Bot <hello@qmk.fm> | 2023-10-12 19:47:06 +0000 |
|---|---|---|
| committer | QMK Bot <hello@qmk.fm> | 2023-10-12 19:47:06 +0000 |
| commit | f4ed65169fc711d7621cdda94d49c9a72edab4cb (patch) | |
| tree | b56481e25322938bea9acaabba5887f771ca90ba /docs | |
| parent | 04b8159d173ec9652cca52b2fcd89e1f6ff5aa86 (diff) | |
| parent | b630df1aa739c285f290333ff2cf7de024b4693e (diff) | |
Merge remote-tracking branch 'origin/master' into develop
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/pr_checklist.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 9bf1b8d005..38c2683694 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -138,7 +138,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - standard layouts preferred in these keymaps, if possible - should use [encoder map feature](https://docs.qmk.fm/#/feature_encoders?id=encoder-map), rather than `encoder_update_user()` - default keymap should not enable VIA -- the VIA integration documentation requires a keymap called `via` -- submitters can have a personal (or bells-and-whistles) keymap showcasing capabilities in the same PR but it shouldn't be embedded in the 'default' keymap +- submitters can add an example (or bells-and-whistles) keymap showcasing capabilities in the same PR but it shouldn't be embedded in the 'default' keymap - submitters can also have a "manufacturer-matching" keymap that mirrors existing functionality of the commercial product, if porting an existing board - Do not include VIA json files in the PR. These do not belong in the QMK repository as they are not used by QMK firmware -- they belong in the [VIA Keyboard Repo](https://github.com/the-via/keyboards) - Do not include KLE json files in the PR. These have no use within QMK. |