summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQMK Bot <hello@qmk.fm>2022-09-21 21:01:00 +0000
committerQMK Bot <hello@qmk.fm>2022-09-21 21:01:00 +0000
commitf28d8999082177d6e28b7b50722b086b0a9e39ec (patch)
tree09839a45bfbbbcea91a42eb6ad4c5d2dd24852b9
parent9b42ee1f6dcbb7c232cf295b3886872569ce0df2 (diff)
parentea80141f6920c115bcf7993eb3173737a580e6d6 (diff)
Merge remote-tracking branch 'origin/master' into develop
-rw-r--r--docs/pr_checklist.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md
index 881f3f282c..6d74e246a8 100644
--- a/docs/pr_checklist.md
+++ b/docs/pr_checklist.md
@@ -135,6 +135,7 @@ Also, specific to ChibiOS:
- for new MCUs, a new "child" keyboard should be added that targets your newly-added MCU, so that builds can be verified
- for new hardware support such as display panels, core-side matrix implementations, or other peripherals, an associated keymap should be provided
- if an existing keymap exists that can leverage this functionality this may not be required (e.g. a new RGB driver chip, supported by the `rgb` keymap) -- consult with the QMK Collaborators on Discord to determine if there is sufficient overlap already
+- any features adding `_kb`/`_user` callbacks must return a `bool`, to allow for user override of keyboard-level callbacks.
- other requirements are at the discretion of QMK collaborators
- core is a lot more subjective given the breadth of posted changes