diff options
| author | Wilhelm Schuster <ws@rot13.io> | 2023-10-12 21:46:28 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-13 06:46:28 +1100 |
| commit | b630df1aa739c285f290333ff2cf7de024b4693e (patch) | |
| tree | 64354abb988a4f3fc0be771ac859399c332a1adf | |
| parent | 999e7213122bd37702e4c501995b81104bc07984 (diff) | |
Reword mention of personal keymaps from PR checklist (#22258)
| -rw-r--r-- | docs/pr_checklist.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 9bf1b8d005..38c2683694 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -138,7 +138,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - standard layouts preferred in these keymaps, if possible - should use [encoder map feature](https://docs.qmk.fm/#/feature_encoders?id=encoder-map), rather than `encoder_update_user()` - default keymap should not enable VIA -- the VIA integration documentation requires a keymap called `via` -- submitters can have a personal (or bells-and-whistles) keymap showcasing capabilities in the same PR but it shouldn't be embedded in the 'default' keymap +- submitters can add an example (or bells-and-whistles) keymap showcasing capabilities in the same PR but it shouldn't be embedded in the 'default' keymap - submitters can also have a "manufacturer-matching" keymap that mirrors existing functionality of the commercial product, if porting an existing board - Do not include VIA json files in the PR. These do not belong in the QMK repository as they are not used by QMK firmware -- they belong in the [VIA Keyboard Repo](https://github.com/the-via/keyboards) - Do not include KLE json files in the PR. These have no use within QMK. |