diff options
| author | precondition <57645186+precondition@users.noreply.github.com> | 2023-02-22 20:03:36 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-22 11:03:36 -0800 |
| commit | 93f2ed3abf909d06334ee51ac687abd782cf68d5 (patch) | |
| tree | 582755f811d91a0365b48573b617fa6e3fcfdc27 | |
| parent | 24a86d5fdbb7502548398cf5d1f0f10014b25003 (diff) | |
[Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY (#19893)
| -rw-r--r-- | quantum/action_tapping.c | 2 | ||||
| -rw-r--r-- | tests/tap_hold_configurations/quick_tap/config.h | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/quantum/action_tapping.c b/quantum/action_tapping.c index 60c7ed4973..5a38bf96e3 100644 --- a/quantum/action_tapping.c +++ b/quantum/action_tapping.c @@ -122,7 +122,7 @@ void action_tapping_process(keyrecord_t record) { * readable. The conditional definition of tapping_keycode and all the * conditional uses of it are hidden inside macros named TAP_... */ -# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(QUICK_TAP_TERM_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) +# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY) # define TAP_DEFINE_KEYCODE uint16_t tapping_keycode = get_record_keycode(&tapping_key, false) # else # define TAP_DEFINE_KEYCODE diff --git a/tests/tap_hold_configurations/quick_tap/config.h b/tests/tap_hold_configurations/quick_tap/config.h index cd82d3b5a5..54a83c50bf 100644 --- a/tests/tap_hold_configurations/quick_tap/config.h +++ b/tests/tap_hold_configurations/quick_tap/config.h @@ -19,3 +19,7 @@ #include "test_common.h" #define QUICK_TAP_TERM 100 +// Although a seemingly superfluous addition since the default per-key function behaves +// no differently from defining a single global QUICK_TAP_TERM, this has been useful +// to catch compilation errors and prevent regressions in the future; see PR #19893. +#define QUICK_TAP_TERM_PER_KEY |