diff options
| author | Zach White <skullydazed@gmail.com> | 2020-11-07 09:56:08 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-07 09:56:08 -0800 |
| commit | 4d33d72975f2d63c7b6ff6fd4aa7e0f4c4347583 (patch) | |
| tree | afc9f0ebeeefed8405443cbe8636458d6c4c18d2 /.github | |
| parent | 7ce5402417b0332569bf48cf2c51e412cd35a18a (diff) | |
New command: qmk lint (#10761)
* Basic qmk lint command
* check for keymap readme
* change the workflow from qmk info to qmk lint
* add a strict mode
* parsing -> parse
* document qmk lint
* small info logging cleanup
* Apply suggestions from code review
Co-authored-by: Ryan <fauxpark@gmail.com>
* honor --strict in more places
* change the job name to lint
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/lint.yml (renamed from .github/workflows/info.yml) | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/.github/workflows/info.yml b/.github/workflows/lint.yml index bb3a508477..1aa347a1b2 100644 --- a/.github/workflows/info.yml +++ b/.github/workflows/lint.yml @@ -6,7 +6,7 @@ on: - 'keyboards/**' jobs: - info: + lint: runs-on: ubuntu-latest container: qmkfm/base_container @@ -27,7 +27,7 @@ jobs: echo ${{ github.event.pull_request.base.sha }} echo '${{ steps.file_changes.outputs.files}}' - - name: Run qmk info + - name: Run qmk lint shell: 'bash {0}' run: | QMK_CHANGES=$(echo -e '${{ steps.file_changes.outputs.files}}') @@ -45,10 +45,7 @@ jobs: if [[ $KEYMAP_ONLY -gt 0 ]]; then echo "linting ${KB}" - # TODO: info info always returns 0 - right now the only way to know failure is to inspect log lines - qmk info -l -kb ${KB} 2>&1 | tee /tmp/$$ - !(grep -cq ☒ /tmp/$$) - : $((exit_code = $exit_code + $?)) + qmk lint --keyboard ${KB} fi done exit $exit_code |