summaryrefslogtreecommitdiff
path: root/tmk_core
diff options
context:
space:
mode:
authorpurple-rw <32964049+purple-rw@users.noreply.github.com>2021-03-25 05:13:41 -0700
committerGitHub <noreply@github.com>2021-03-25 23:13:41 +1100
commit5c1442766c10e98a0152b847ccf4d48899558cea (patch)
tree5fb4680ffc3dedaf8e51b1b14437e9642148f225 /tmk_core
parent816f2f9cc234b5a98512a483b2781b1c2875f24f (diff)
fix permissive hold when both PERMISSIVE_HOLD_PER_KEY and TAPPING_TERM_PER_KEY are defined (#12125)
Co-authored-by: checyr <32964049+checyr@users.noreply.github.com>
Diffstat (limited to 'tmk_core')
-rw-r--r--tmk_core/common/action_tapping.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/tmk_core/common/action_tapping.c b/tmk_core/common/action_tapping.c
index fe545c79a0..25b200448f 100644
--- a/tmk_core/common/action_tapping.c
+++ b/tmk_core/common/action_tapping.c
@@ -121,12 +121,20 @@ bool process_tapping(keyrecord_t *keyp) {
*/
# if defined(TAPPING_TERM_PER_KEY) || (TAPPING_TERM >= 500) || defined(PERMISSIVE_HOLD) || defined(PERMISSIVE_HOLD_PER_KEY)
else if (
+ ((
# ifdef TAPPING_TERM_PER_KEY
- (get_tapping_term(get_event_keycode(tapping_key.event, false), keyp) >= 500) &&
+ get_tapping_term(get_event_keycode(tapping_key.event, false), keyp)
+# else
+ TAPPING_TERM
# endif
+ >= 500 )
+
# ifdef PERMISSIVE_HOLD_PER_KEY
- !get_permissive_hold(get_event_keycode(tapping_key.event, false), keyp) &&
+ || get_permissive_hold(get_event_keycode(tapping_key.event, false), keyp)
+# elif defined(PERMISSIVE_HOLD)
+ || true
# endif
+ ) &&
IS_RELEASED(event) && waiting_buffer_typed(event)) {
debug("Tapping: End. No tap. Interfered by typing key\n");
process_record(&tapping_key);