diff options
| author | Joshua Diamond <josh@windowoffire.com> | 2022-12-15 03:18:54 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-15 00:18:54 -0800 |
| commit | 571a9794af0249ef23a0af2ed2ee64191299faa7 (patch) | |
| tree | b7833c71c081b48160c540758184b632d41c0e5a /quantum | |
| parent | 8e50f1c5f5ba1cb70c01a63bbee8882cf7e50534 (diff) | |
Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (#19335)
Diffstat (limited to 'quantum')
| -rw-r--r-- | quantum/rgblight/rgblight.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/quantum/rgblight/rgblight.c b/quantum/rgblight/rgblight.c index f832854c5f..19d80e0097 100644 --- a/quantum/rgblight/rgblight.c +++ b/quantum/rgblight/rgblight.c @@ -1480,6 +1480,8 @@ void rgblight_effect_twinkle(animation_status_t *anim) { return (v * scale) >> 8; } + const uint8_t trigger = scale((uint16_t)0xFF * RGBLIGHT_EFFECT_TWINKLE_PROBABILITY, 127 + rgblight_config.val / 2); + for (uint8_t i = 0; i < rgblight_ranges.effect_num_leds; i++) { TwinkleState *t = &(led_twinkle_state[i]); HSV * c = &(t->hsv); @@ -1498,7 +1500,7 @@ void rgblight_effect_twinkle(animation_status_t *anim) { t->life--; uint8_t unscaled = frac(breathe_calc(frac(t->life, t->max_life)) - bottom, top - bottom); c->v = scale(rgblight_config.val, unscaled); - } else if (rand() < scale((uint16_t)RAND_MAX * RGBLIGHT_EFFECT_TWINKLE_PROBABILITY, 127 + rgblight_config.val / 2)) { + } else if ((rand() % 0xFF) < trigger) { // This LED is off, but was randomly selected to start brightening if (random_color) { c->h = rand() % 0xFF; |