summaryrefslogtreecommitdiff
path: root/quantum
diff options
context:
space:
mode:
authorPablo Martínez <58857054+elpekenin@users.noreply.github.com>2023-04-03 04:42:46 +0200
committerGitHub <noreply@github.com>2023-04-03 12:42:46 +1000
commit15a106b1ef1bb760d6a48b2fd17bc0ed2606541a (patch)
treef96a1e220cfbd9adb0ed86f730c39e04a9f2e194 /quantum
parentac9f9f9efbd3d5f25fee64be4de7c525ebab8a70 (diff)
[Bugfix] Check QGF's bpp against display's native_bits_per_pixel (#19995)
Diffstat (limited to 'quantum')
-rw-r--r--quantum/painter/qp_draw_image.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/quantum/painter/qp_draw_image.c b/quantum/painter/qp_draw_image.c
index fa80617242..073f1da8eb 100644
--- a/quantum/painter/qp_draw_image.c
+++ b/quantum/painter/qp_draw_image.c
@@ -273,6 +273,10 @@ static bool qp_drawimage_recolor_impl(painter_device_t device, uint16_t x, uint1
if (ret && output_state.pixel_write_pos > 0) {
ret &= driver->driver_vtable->pixdata(device, qp_internal_global_pixdata_buffer, output_state.pixel_write_pos);
}
+ } else if (frame_info->bpp != driver->native_bits_per_pixel) {
+ // Prevent stuff like drawing 24bpp images on 16bpp displays
+ qp_dprintf("Image's bpp doesn't match the target display's native_bits_per_pixel\n");
+ return false;
} else {
// Set up the output state
struct qp_internal_byte_output_state output_state = {.device = device, .byte_write_pos = 0, .max_bytes = qp_internal_num_pixels_in_buffer(device) * driver->native_bits_per_pixel / 8};