diff options
| author | Joel Challis <git@zvecr.com> | 2022-12-09 01:42:22 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-09 01:42:22 +0000 |
| commit | 99cd0b13e109bb14f1e5af023c5fcb5e50a78e0a (patch) | |
| tree | f6b3198bca1321fb9f4b8c0903d87869a8816630 /keyboards/lfkeyboards | |
| parent | ba6ee2904066aa64fa83417dc865f24dc76d991b (diff) | |
Refactor some led_set_kb instances (#19179)
* Refactor some led_set_kb instances
* Apply suggestions from code review
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'keyboards/lfkeyboards')
| -rw-r--r-- | keyboards/lfkeyboards/lfk78/lfk78.c | 10 | ||||
| -rw-r--r-- | keyboards/lfkeyboards/lfk87/lfk87.c | 18 | ||||
| -rw-r--r-- | keyboards/lfkeyboards/mini1800/mini1800.c | 18 |
3 files changed, 26 insertions, 20 deletions
diff --git a/keyboards/lfkeyboards/lfk78/lfk78.c b/keyboards/lfkeyboards/lfk78/lfk78.c index 6f61d6e2e2..110bbd4168 100644 --- a/keyboards/lfkeyboards/lfk78/lfk78.c +++ b/keyboards/lfkeyboards/lfk78/lfk78.c @@ -151,11 +151,12 @@ void reset_keyboard_kb() { reset_keyboard(); } -void led_set_kb(uint8_t usb_led) { - // put your keyboard LED indicator (ex: Caps Lock LED) toggling code here +bool led_update_kb(led_t led_state) { + bool res = led_update_user(led_state); + if(res) { #ifdef ISSI_ENABLE # ifdef CAPSLOCK_LED - if (usb_led & (1 << USB_LED_CAPS_LOCK)) { + if (led_state.caps_lock) { activateLED(0, 3, 7, 255); } else { activateLED(0, 3, 7, 0); @@ -163,7 +164,8 @@ void led_set_kb(uint8_t usb_led) { # endif // CAPSLOCK_LED #endif // ISS_ENABLE - led_set_user(usb_led); + } + return res; } // LFK lighting info diff --git a/keyboards/lfkeyboards/lfk87/lfk87.c b/keyboards/lfkeyboards/lfk87/lfk87.c index 553c66da6d..18ddd86adc 100644 --- a/keyboards/lfkeyboards/lfk87/lfk87.c +++ b/keyboards/lfkeyboards/lfk87/lfk87.c @@ -128,15 +128,17 @@ void reset_keyboard_kb(){ reset_keyboard(); } -void led_set_kb(uint8_t usb_led) -{ - // Set capslock LED to Blue - if (usb_led & (1 << USB_LED_CAPS_LOCK)) { - set_rgb(31, 0x00, 0x00, 0x7F); - }else{ - set_rgb(31, 0x00, 0x00, 0x00); +bool led_update_kb(led_t led_state) { + bool res = led_update_user(led_state); + if(res) { + // Set capslock LED to Blue + if (led_state.caps_lock) { + set_rgb(31, 0x00, 0x00, 0x7F); + } else{ + set_rgb(31, 0x00, 0x00, 0x00); + } } - led_set_user(usb_led); + return res; } // Lighting info, see lighting.h for details diff --git a/keyboards/lfkeyboards/mini1800/mini1800.c b/keyboards/lfkeyboards/mini1800/mini1800.c index ac6b0533b4..cf7e42f134 100644 --- a/keyboards/lfkeyboards/mini1800/mini1800.c +++ b/keyboards/lfkeyboards/mini1800/mini1800.c @@ -134,15 +134,17 @@ void reset_keyboard_kb(){ reset_keyboard(); } -void led_set_kb(uint8_t usb_led) -{ - // Set capslock LED to Blue - if (usb_led & (1 << USB_LED_CAPS_LOCK)) { - set_rgb(31, 0x00, 0x00, 0x7F); - }else{ - set_rgb(31, 0x00, 0x00, 0x00); +bool led_update_kb(led_t led_state) { + bool res = led_update_user(led_state); + if(res) { + // Set capslock LED to Blue + if (led_state.caps_lock) { + set_rgb(31, 0x00, 0x00, 0x7F); + } else{ + set_rgb(31, 0x00, 0x00, 0x00); + } } - led_set_user(usb_led); + return res; } // Lighting info, see lighting.h for details |