diff options
author | Erez Zukerman <bulk@ezuk.org> | 2016-03-22 21:30:25 +0200 |
---|---|---|
committer | Erez Zukerman <bulk@ezuk.org> | 2016-03-22 21:30:25 +0200 |
commit | 403d756ad56de18488e3d048e849c55e77a20b32 (patch) | |
tree | b02cd9a378a29d9b8cde07a7d97b46c24e74a3b1 /keyboard/atomic | |
parent | 7f0d77e08c6b5d75a1f912051e6d2928d66e7c3b (diff) | |
parent | baeffd99da5603cd5156bbcf0cd45ae62711858f (diff) |
Merge pull request #190 from yoyoerx/function_pointers
Addressing void* return warning & coding style
Diffstat (limited to 'keyboard/atomic')
-rw-r--r-- | keyboard/atomic/atomic.c | 24 | ||||
-rw-r--r-- | keyboard/atomic/atomic.h | 4 |
2 files changed, 12 insertions, 16 deletions
diff --git a/keyboard/atomic/atomic.c b/keyboard/atomic/atomic.c index fa66266a4c..30e8122893 100644 --- a/keyboard/atomic/atomic.c +++ b/keyboard/atomic/atomic.c @@ -1,16 +1,16 @@ #include "atomic.h" __attribute__ ((weak)) -void * matrix_init_user(void) { +void matrix_init_user(void) { // leave these blank -}; +} __attribute__ ((weak)) -void * matrix_scan_user(void) { +void matrix_scan_user(void) { // leave these blank -}; +} -void * matrix_init_kb(void) { +void matrix_init_kb(void) { // put your keyboard start-up code here // runs once when the firmware starts up @@ -25,16 +25,12 @@ void * matrix_init_kb(void) { DDRE |= (1<<6); PORTE |= (1<<6); - if (matrix_init_user) { - (*matrix_init_user)(); - } -}; + matrix_init_user(); +} -void * matrix_scan_kb(void) { +void matrix_scan_kb(void) { // put your looping keyboard code here // runs every cycle (a lot) - if (matrix_scan_user) { - (*matrix_scan_user)(); - } -};
\ No newline at end of file + matrix_scan_user(); +}
\ No newline at end of file diff --git a/keyboard/atomic/atomic.h b/keyboard/atomic/atomic.h index 95982ecad1..d8574efa93 100644 --- a/keyboard/atomic/atomic.h +++ b/keyboard/atomic/atomic.h @@ -24,7 +24,7 @@ { K40, K41, KC_NO, K43, KC_NO, KC_NO, K46, KC_NO, KC_NO, KC_NO, K4A, K4B, K4C, K4D, K4E } \ } -void * matrix_init_user(void); -void * matrix_scan_user(void); +void matrix_init_user(void); +void matrix_scan_user(void); #endif
\ No newline at end of file |