diff options
| author | Nick Brassel <nick@tzarc.org> | 2023-05-29 06:02:11 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-29 06:02:11 +1000 |
| commit | 32d865572cd87a5f68ac9b09e20dffc1bcba69dd (patch) | |
| tree | 237e259164601800ac7d56fde5aac42e49af1440 /docs/pr_checklist.md | |
| parent | 8c9f54d70b12156781ba5757697079b83dff79a7 (diff) | |
`develop` 2023q2 changelog (#21049)
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'docs/pr_checklist.md')
| -rw-r--r-- | docs/pr_checklist.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 6dc6c0000d..65584a9538 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -62,7 +62,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - valid maintainer - valid USB VID/PID and device version - displays correctly in Configurator (press Ctrl+Shift+I to preview local file, turn on fast input to verify ordering) - - `layout` definitions should include matrix positions, so that `LAYOUT` macros can be generated at build time + - `layout` definitions must include matrix positions, so that `LAYOUT` macros can be generated at build time - should use standard definitions if applicable - use the Community Layout macro names where they apply (preferred above `LAYOUT`/`LAYOUT_all`) - If the keyboard only has a single electrical/switch layout: @@ -124,7 +124,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - hardware that's enabled at the keyboard level and requires configuration such as OLED displays or encoders should have basic functionality implemented here - `<keyboard>.h` - `#include "quantum.h"` appears at the top - - `LAYOUT` macros should be moved to `info.json` + - `LAYOUT` macros are no longer accepted and should instead be moved to `info.json` - keymap `config.h` - no duplication of `rules.mk` or `config.h` from keyboard - `keymaps/default/keymap.c` |