summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoakim Tufvegren <jocke@barbanet.com>2021-07-12 17:43:05 +0200
committerGitHub <noreply@github.com>2021-07-12 08:43:05 -0700
commit4706231831b7b5926052ee1affc7f38a165c7761 (patch)
tree8296bbe30b5afd84c7db55a23db8bea6bbb32105
parent89980ff0044c17a9eeb58007ae35330f1d58605b (diff)
Fix two out of bounds accesses from #13330. (#13525)
Two occurrences of `MATRIX_ROWS` weren't properly changed to `ROWS_PER_HAND` in #13330, causing a crash during boot on at least my Ergodox Infinity (including #13481).
-rw-r--r--quantum/matrix.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/quantum/matrix.c b/quantum/matrix.c
index ed4643f813..235b16769f 100644
--- a/quantum/matrix.c
+++ b/quantum/matrix.c
@@ -149,7 +149,7 @@ static void unselect_row(uint8_t row) {
}
static void unselect_rows(void) {
- for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
+ for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
unselect_row(x);
}
}
@@ -214,7 +214,7 @@ static void unselect_cols(void) {
__attribute__((weak)) void matrix_init_pins(void) {
unselect_cols();
- for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
+ for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
if (row_pins[x] != NO_PIN) {
setPinInputHigh_atomic(row_pins[x]);
}