summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlbert Y <76888457+filterpaper@users.noreply.github.com>2023-01-17 09:54:51 +0800
committerGitHub <noreply@github.com>2023-01-16 17:54:51 -0800
commit0ff52925c08184af0a991319b0d2ee84446463ac (patch)
tree9c82d79c91957c7d29f8544cf00b8a701850ec4e
parent7acc3f444993c77ad65836933c4daecbae57d034 (diff)
Refactor pixel rain animation (#19606)
-rw-r--r--quantum/rgb_matrix/animations/pixel_rain_anim.h12
1 files changed, 6 insertions, 6 deletions
diff --git a/quantum/rgb_matrix/animations/pixel_rain_anim.h b/quantum/rgb_matrix/animations/pixel_rain_anim.h
index ccea8d976a..9d63f451e2 100644
--- a/quantum/rgb_matrix/animations/pixel_rain_anim.h
+++ b/quantum/rgb_matrix/animations/pixel_rain_anim.h
@@ -12,23 +12,23 @@ static bool PIXEL_RAIN(effect_params_t* params) {
return 500 / scale16by8(qadd8(rgb_matrix_config.speed, 16), 16);
}
- void rain_pixel(uint8_t i, effect_params_t * params, bool off) {
- if (!HAS_ANY_FLAGS(g_led_config.flags[i], params->flags)) {
+ inline void rain_pixel(uint8_t led_index) {
+ if (!HAS_ANY_FLAGS(g_led_config.flags[led_index], params->flags)) {
return;
}
- if (off) {
- rgb_matrix_set_color(i, 0, 0, 0);
+ if (random8() & 2) {
+ rgb_matrix_set_color(led_index, 0, 0, 0);
} else {
HSV hsv = {random8(), random8_min_max(127, 255), rgb_matrix_config.hsv.v};
RGB rgb = rgb_matrix_hsv_to_rgb(hsv);
- rgb_matrix_set_color(i, rgb.r, rgb.g, rgb.b);
+ rgb_matrix_set_color(led_index, rgb.r, rgb.g, rgb.b);
}
wait_timer = g_rgb_timer + interval();
}
RGB_MATRIX_USE_LIMITS(led_min, led_max);
if (g_rgb_timer > wait_timer) {
- rain_pixel(random8_max(RGB_MATRIX_LED_COUNT), params, random8() & 2);
+ rain_pixel(random8_max(RGB_MATRIX_LED_COUNT));
}
return rgb_matrix_check_finished_leds(led_max);
}