From 445a738b9ebfd93f65fecd68a5fbbe61b7951bf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kjetil=20=C3=98rbekk?= Date: Wed, 2 May 2012 12:54:04 +0200 Subject: Fix VariableUpdaterTask. Use CyclicCountDownLatch to improve VariableUpdaterTask. This implementation is much better, but unfortunately really hard to test. I'm not sure how to test this. --- .../com/orbekk/same/VariableUpdaterTaskTest.java | 76 ---------------------- 1 file changed, 76 deletions(-) delete mode 100644 same/src/test/java/com/orbekk/same/VariableUpdaterTaskTest.java (limited to 'same/src/test/java/com') diff --git a/same/src/test/java/com/orbekk/same/VariableUpdaterTaskTest.java b/same/src/test/java/com/orbekk/same/VariableUpdaterTaskTest.java deleted file mode 100644 index 026545a..0000000 --- a/same/src/test/java/com/orbekk/same/VariableUpdaterTaskTest.java +++ /dev/null @@ -1,76 +0,0 @@ -/** - * Copyright 2012 Kjetil Ørbekk - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package com.orbekk.same; - -import org.junit.Before; -import org.junit.Test; -import static org.mockito.Mockito.*; - -@SuppressWarnings("unchecked") -public class VariableUpdaterTaskTest { - Variable v; - VariableUpdaterTask updater; - - @Before public void setUp() { - v = mock(Variable.class); - updater = new VariableUpdaterTask(v); - } - - @Test - public void updatesValue() { - updater.set("FirstValue"); - updater.performWork(); - verify(v).set("FirstValue"); - } - - @Test - public void noUpdateIfNotSet() { - updater.set("FirstValue"); - updater.performWork(); - reset(v); - updater.performWork(); - verify(v, never()).set(anyString()); - } - - @Test - public void noUpdateIfNotReady() { - updater.set("FirstValue"); - updater.performWork(); - reset(v); - updater.set("SecondValue"); - updater.performWork(); - verify(v, never()).set(anyString()); - } - - @Test - public void updatesWhenReady() { - updater.set("Value1"); - updater.performWork(); - reset(v); - updater.valueChanged(null); - updater.set("Value2"); - updater.performWork(); - verify(v).set("Value2"); - } - - @Test - public void choosesLastUpdate() { - updater.set("FirstValue"); - updater.set("SecondValue"); - updater.performWork(); - verify(v).set("SecondValue"); - } -} -- cgit v1.2.3