From f4a71e0d8a17a39b856e20122df60d51326f2cd0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kjetil=20=C3=98rbekk?= <kjetil.orbekk@gmail.com>
Date: Mon, 30 Apr 2012 15:58:22 +0200
Subject: Fix error handling in ConnectionManagerImpl.

---
 .../com/orbekk/same/ConnectionManagerImpl.java     | 24 ++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

(limited to 'same/src/main/java/com/orbekk/same/ConnectionManagerImpl.java')

diff --git a/same/src/main/java/com/orbekk/same/ConnectionManagerImpl.java b/same/src/main/java/com/orbekk/same/ConnectionManagerImpl.java
index 280df9b..e76b9f8 100644
--- a/same/src/main/java/com/orbekk/same/ConnectionManagerImpl.java
+++ b/same/src/main/java/com/orbekk/same/ConnectionManagerImpl.java
@@ -35,11 +35,31 @@ public class ConnectionManagerImpl implements ConnectionManager {
         this.readTimeout = readTimeout;
     }
 
+    private boolean isValidLocation(String location) {
+        String[] args = location.split(":");
+        if (args.length != 2) {
+            logger.error("Invalid location: " + location);
+            return false;
+        }
+        try {
+            Integer.valueOf(args[1]);
+        } catch (IllegalArgumentException e) {
+            logger.error("Invalid location: " + location);
+            return false;
+        }
+        return true;
+    }
+    
     private RpcChannel getChannel(String location) {
         Future<RpcChannel> channel = channels.get(location);
         if (channel == null) {
-            final String hostname = location.split(":")[0];
-            final int port = Integer.valueOf(location.split(":")[1]);
+            if (!isValidLocation(location)) {
+                return null;
+            }
+            String[] args = location.split(":");
+            final String hostname = args[0];
+            final int port = Integer.valueOf(args[1]);
+            
             Callable<RpcChannel> channelFactory =
                     new Callable<RpcChannel>() {
                 @Override public RpcChannel call() {
-- 
cgit v1.2.3