From cbabc8dbe6a8476d3082e8bc649d330f87e7b904 Mon Sep 17 00:00:00 2001 From: Albert Y <76888457+filterpaper@users.noreply.github.com> Date: Mon, 12 Dec 2022 23:52:22 +0800 Subject: [Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007) * Replace Tapping Force Hold feature with Quick Tap Term * Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0 * Deprecate force hold in info_config.json * Before and after quick tap term unit tests * Quick tap unit tests iteration * Keymap config.h correction * Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed * Add two more test cases for quick tap * Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2 * Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2 * Add function declaration for get_quick_tap_term Co-authored-by: Stefan Kerkmann --- users/ridingqwerty/config.h | 2 +- users/ridingqwerty/ridingqwerty.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'users/ridingqwerty') diff --git a/users/ridingqwerty/config.h b/users/ridingqwerty/config.h index 6501efe62f..291c4877e1 100644 --- a/users/ridingqwerty/config.h +++ b/users/ridingqwerty/config.h @@ -5,7 +5,7 @@ #define TAPPING_TERM 175 #define MACRO_TIMER 5 -#define TAPPING_FORCE_HOLD_PER_KEY +#define QUICK_TAP_TERM_PER_KEY // testing #define TAPPING_TERM_PER_KEY //#define IGNORE_MOD_TAP_INTERRUPT // rolling R3 "zxcv", etc... diff --git a/users/ridingqwerty/ridingqwerty.c b/users/ridingqwerty/ridingqwerty.c index 8934b9365b..639bb8d2b3 100644 --- a/users/ridingqwerty/ridingqwerty.c +++ b/users/ridingqwerty/ridingqwerty.c @@ -55,11 +55,11 @@ uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record) { } }; -bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) { - switch (keycode) { - case NM(SCLN): - return true; - default: - return false; - } +uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) { + switch (keycode) { + case NM(SCLN): + return 0; + default: + return QUICK_TAP_TERM; + } } -- cgit v1.2.3 From 1978007faefc0fb3af809ddf0d2ff1274e540570 Mon Sep 17 00:00:00 2001 From: Ryan Date: Thu, 15 Dec 2022 07:40:25 +1100 Subject: Tap Dance: remove `qk_` prefix (#19313) --- users/ridingqwerty/tapdances.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'users/ridingqwerty') diff --git a/users/ridingqwerty/tapdances.c b/users/ridingqwerty/tapdances.c index 644166cb45..0fdd941637 100644 --- a/users/ridingqwerty/tapdances.c +++ b/users/ridingqwerty/tapdances.c @@ -1,13 +1,13 @@ #include "ridingqwerty.h" #include "tapdances.h" -void braces_finished (qk_tap_dance_state_t *state, void *user_data) { +void braces_finished (tap_dance_state_t *state, void *user_data) { if ((state->count == 1) || (state->count == 3)) { register_code(KC_LSFT); } } -void braces_reset (qk_tap_dance_state_t *state, void *user_data) { +void braces_reset (tap_dance_state_t *state, void *user_data) { // two or three taps for "[]"/"{}" if ((state->count == 2) || (state->count == 3)) { tap_code(KC_LBRC); @@ -28,6 +28,6 @@ void braces_reset (qk_tap_dance_state_t *state, void *user_data) { } } -qk_tap_dance_action_t tap_dance_actions[] = { +tap_dance_action_t tap_dance_actions[] = { [TD_BRACES] = ACTION_TAP_DANCE_FN_ADVANCED (NULL, braces_finished, braces_reset) }; -- cgit v1.2.3 From d0ebafaea6847926e6391a6920821bcb17b3c39c Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Sun, 1 Jan 2023 00:54:12 +0000 Subject: Align definition of unicode_map (#19452) --- users/ridingqwerty/unicode.c | 2 +- users/ridingqwerty/unicode.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'users/ridingqwerty') diff --git a/users/ridingqwerty/unicode.c b/users/ridingqwerty/unicode.c index 8ef5aaa1ec..5a4c154919 100644 --- a/users/ridingqwerty/unicode.c +++ b/users/ridingqwerty/unicode.c @@ -1,7 +1,7 @@ #include "unicode.h" #ifdef UNICODEMAP_ENABLE -const uint32_t PROGMEM unicode_map[] = { +const uint32_t unicode_map[] PROGMEM = { FOREACH_UNICODE(UCM_ENTRY) }; #endif diff --git a/users/ridingqwerty/unicode.h b/users/ridingqwerty/unicode.h index 8b403272ae..de8d1593b4 100644 --- a/users/ridingqwerty/unicode.h +++ b/users/ridingqwerty/unicode.h @@ -227,7 +227,7 @@ enum unicode_names { FOREACH_UNICODE(UCM_NAME) }; -extern const uint32_t PROGMEM unicode_map[]; +extern const uint32_t unicode_map[] PROGMEM; enum unicode_keycodes { FOREACH_UNICODE(UCM_KEYCODE) -- cgit v1.2.3