From cbabc8dbe6a8476d3082e8bc649d330f87e7b904 Mon Sep 17 00:00:00 2001 From: Albert Y <76888457+filterpaper@users.noreply.github.com> Date: Mon, 12 Dec 2022 23:52:22 +0800 Subject: [Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007) * Replace Tapping Force Hold feature with Quick Tap Term * Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0 * Deprecate force hold in info_config.json * Before and after quick tap term unit tests * Quick tap unit tests iteration * Keymap config.h correction * Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed * Add two more test cases for quick tap * Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2 * Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2 * Add function declaration for get_quick_tap_term Co-authored-by: Stefan Kerkmann --- users/muppetjones/config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'users/muppetjones') diff --git a/users/muppetjones/config.h b/users/muppetjones/config.h index 3dd4d1b1b6..583567d4f3 100644 --- a/users/muppetjones/config.h +++ b/users/muppetjones/config.h @@ -34,7 +34,7 @@ # define IGNORE_MOD_TAP_INTERRUPT // Enable rapid switch from tap to hold, disables double tap hold auto-repeat. -# define TAPPING_FORCE_HOLD +# define QUICK_TAP_TERM 0 #endif -- cgit v1.2.3 From 1978007faefc0fb3af809ddf0d2ff1274e540570 Mon Sep 17 00:00:00 2001 From: Ryan Date: Thu, 15 Dec 2022 07:40:25 +1100 Subject: Tap Dance: remove `qk_` prefix (#19313) --- users/muppetjones/features/dancelayers.c | 6 +++--- users/muppetjones/features/dancelayers.h | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'users/muppetjones') diff --git a/users/muppetjones/features/dancelayers.c b/users/muppetjones/features/dancelayers.c index e7e5f2a6f2..3744950a4f 100644 --- a/users/muppetjones/features/dancelayers.c +++ b/users/muppetjones/features/dancelayers.c @@ -27,7 +27,7 @@ static td_tap_t lyr_tap_state = {.is_press_action = true, .state = TD_NONE}; * @param A tap dance state struct. * @return A struct. */ -td_state_t cur_dance(qk_tap_dance_state_t *state) { +td_state_t cur_dance(tap_dance_state_t *state) { switch (state->count) { case 1: if (!state->pressed) @@ -49,7 +49,7 @@ td_state_t cur_dance(qk_tap_dance_state_t *state) { } // Functions that control what our tap dance key does -__attribute__((weak)) void td_layer_finished(qk_tap_dance_state_t *state, void *user_data) { +__attribute__((weak)) void td_layer_finished(tap_dance_state_t *state, void *user_data) { lyr_tap_state.state = cur_dance(state); switch (lyr_tap_state.state) { case TD_1X_TAP: @@ -87,7 +87,7 @@ __attribute__((weak)) void td_layer_finished(qk_tap_dance_state_t *state, void * } } -__attribute__((weak)) void td_layer_reset(qk_tap_dance_state_t *state, void *user_data) { +__attribute__((weak)) void td_layer_reset(tap_dance_state_t *state, void *user_data) { // If the key was held down and now is released then switch off the layer if (lyr_tap_state.state == TD_1X_HOLD) { layer_off(_ADJUST); diff --git a/users/muppetjones/features/dancelayers.h b/users/muppetjones/features/dancelayers.h index 23defcca92..5f7440f48b 100644 --- a/users/muppetjones/features/dancelayers.h +++ b/users/muppetjones/features/dancelayers.h @@ -51,7 +51,7 @@ typedef struct { * @param A tap dance state struct. * @return A struct. */ -td_state_t cur_dance(qk_tap_dance_state_t *state); +td_state_t cur_dance(tap_dance_state_t *state); // Functions associated with individual tap dances @@ -63,7 +63,7 @@ td_state_t cur_dance(qk_tap_dance_state_t *state); * @param user_data Pointer to user data. * @return None. */ -void td_layer_finished(qk_tap_dance_state_t *state, void *user_data); +void td_layer_finished(tap_dance_state_t *state, void *user_data); /* @brief Reset tap dance actions. * @@ -73,10 +73,10 @@ void td_layer_finished(qk_tap_dance_state_t *state, void *user_data); * @param user_data Pointer to user data. * @return None. */ -void td_layer_reset(qk_tap_dance_state_t *state, void *user_data); +void td_layer_reset(tap_dance_state_t *state, void *user_data); /* Define tap dance actions. */ __attribute__((weak)) -qk_tap_dance_action_t tap_dance_actions[1] = {[TD_LAYERS] = ACTION_TAP_DANCE_FN_ADVANCED_TIME(NULL, td_layer_finished, td_layer_reset, 275)}; +tap_dance_action_t tap_dance_actions[1] = {[TD_LAYERS] = ACTION_TAP_DANCE_FN_ADVANCED_TIME(NULL, td_layer_finished, td_layer_reset, 275)}; #endif -- cgit v1.2.3 From 043d8e1140e09327b72ed3bd55f369e1faf1a334 Mon Sep 17 00:00:00 2001 From: Ryan Date: Mon, 30 Jan 2023 03:44:16 +1100 Subject: Remove deprecated Quantum keycodes (#19712) --- users/muppetjones/wrappers.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'users/muppetjones') diff --git a/users/muppetjones/wrappers.h b/users/muppetjones/wrappers.h index 9bcf81857c..9c6b25481d 100644 --- a/users/muppetjones/wrappers.h +++ b/users/muppetjones/wrappers.h @@ -165,8 +165,6 @@ * | Play | Stop | Next | Prev | Mute | * `----------------------------------' */ -// What it MUV_IN and MUV_DE (5C2A and B)? -// https://github.com/qmk/qmk_firmware/blob/7e832e46de26989b81f2fbf58a0f391b2b0c1aaf/quantum/quantum_keycodes.h#L135 #define __MEDIA_R1_________________________________ AU_ON, MI_ON, MU_ON, KC_BRMU, KC_VOLU #define __MEDIA_R2_________________________________ AU_OFF, MI_OFF, MU_OFF, KC_BRMD, KC_VOLD #define __MEDIA_R3_________________________________ KC_MPLY, KC_MSTP, KC_MNXT, KC_MPRV, KC_MUTE -- cgit v1.2.3