From a9e5e230634e61210401631a60369b346e76381a Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Thu, 13 Oct 2022 04:17:20 +0100 Subject: Remove keymaps that still reference legacy macros (#18693) --- keyboards/planck/keymaps/cbbrowne/config.h | 43 ---- keyboards/planck/keymaps/cbbrowne/keymap.c | 359 --------------------------- keyboards/planck/keymaps/cbbrowne/readme.org | 117 --------- keyboards/planck/keymaps/cbbrowne/rules.mk | 20 -- 4 files changed, 539 deletions(-) delete mode 100644 keyboards/planck/keymaps/cbbrowne/config.h delete mode 100644 keyboards/planck/keymaps/cbbrowne/keymap.c delete mode 100644 keyboards/planck/keymaps/cbbrowne/readme.org delete mode 100644 keyboards/planck/keymaps/cbbrowne/rules.mk (limited to 'keyboards/planck/keymaps/cbbrowne') diff --git a/keyboards/planck/keymaps/cbbrowne/config.h b/keyboards/planck/keymaps/cbbrowne/config.h deleted file mode 100644 index 87953c339e..0000000000 --- a/keyboards/planck/keymaps/cbbrowne/config.h +++ /dev/null @@ -1,43 +0,0 @@ -/* Copyright 2017 Christopher Browne - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation, either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ - -#pragma once - -#ifndef NO_DEBUG -#define NO_DEBUG -#endif -#ifndef NO_PRINT -#define NO_PRINT -#endif - -#include "../../config.h" - -#define LEADER_TIMEOUT 300 - -#ifndef KEYBOARD_planck_light -#define BACKLIGHT_BREATHING -#endif - -/* cbbrowne user configuration */ - -#define randadd 53 -#define randmul 181 -#define randmod 167 - -/* Filler to make layering a bit clearer * - * borrowed from basic keymap */ - -#define _____ KC_NO diff --git a/keyboards/planck/keymaps/cbbrowne/keymap.c b/keyboards/planck/keymaps/cbbrowne/keymap.c deleted file mode 100644 index 22e0cbc492..0000000000 --- a/keyboards/planck/keymaps/cbbrowne/keymap.c +++ /dev/null @@ -1,359 +0,0 @@ -#include QMK_KEYBOARD_H -#include "version.h" - -/* Each layer is given a name to aid in readability, which is then - used in the keymap matrix below. The underscores do not denote - anything - you can have a layer called STUFF or any other name. - - Layer names don't all need to be of the same length, obviously, and - you could also skip them entirely and just use numbers, though that - means needing to manage the numbers. - - It is preferable to keep the symbols short so that a line worth of - key mappings fits compactly onto a line of code. */ - -/* This was originally based on planck/keymaps/default/default.c, and - then cbbrowne has revised things */ - -/* Things I did not like about the default mapping - - - I found control too hard to get to. I use it more than Tab, so - switched it there. - - Having dash on [lower-j] is a bit nonintuitive, but may be OK - - I'll bet I should switch ESC/TAB - - I'm suspicious that I want to shift M(0) from [4][1] to [4][2], - and shift ESC off the first column so KC_LCTL and KC_LALT can - be on the first column. - - I needed to swap ' and ENTER - - - All of the above are done :-) - - - Dropped out support for Dvorak and friends. They aren't - improvements to me -*/ - - -/* Some interesting things implemented - - - There is a macro that writes out "cbbrowne" just to show that I - could - - There is a (somewhat cruddy) linear congruential random number - generator. - - I seed it somewhat with clock info to make it look more random - - There are two macros that use the random number generators - - one, M_RANDDIGIT, generates a random digit based on state - of the random number generator - - the other, M_RANDLETTER, generates a random letter based on state - of the random number generator - - in both, note the use of register_code()/unregister_code() - to indicate the desired key - - I do indeed want a sweet number pad! -*/ - -/* Other things to do... - - - Need to think about what zsh and readline actions I use lots - - Ought to ensure that Control-Alt-Delete is convenient enough - - How about Alt-F1 thru Alt-F8? Not yet... - - What's the keystroke to get from X to console these days? - - A layer for doing console switching would not be a bad idea - - - I'm messing with jeremy-dev's keymap that shifts everything - outwards. Gotta figure out how to make it sensible... -*/ - -enum layers { - _QWERTY = 0, /* Qwerty mapping */ - _LOWER, /* Lower layer, where top line has symbols !@#$%^&*() */ - _RAISE, /* Raised layer, where top line has digits 1234567890 */ - _KEYPAD, /* Key pad */ - _ADJUST, /* Special Adjust layer coming via tri-placement */ - -}; - -enum my_keycodes { - MY_ABVE = SAFE_RANGE, - MY_BELW, - MY_TERM, - MY_DEQL, // /= - MY_MEQL, // *= - MY_SEQL, // -= - MY_PEQL, // += - MY_NEQL, // != - MY_LTGT, // <> - MY_DPIP, // || - MY_DAMP, // && -}; - -enum macro_id { - M_LED = 0, - M_USERNAME, - M_RANDDIGIT, - M_RANDLETTER, - M_VERSION, - MACRO_UPPER, - MACRO_LOWER, -}; - -#define M_LOWER M(MACRO_LOWER) -#define M_UPPER M(MACRO_UPPER) -#define ROT_LED M(M_LED) /* Rotate LED */ -#define QWERTY DF(_QWERTY) /* Switch to QWERTY layout */ -#define KEYPAD DF(_KEYPAD) /* Switch to keypad */ -#define USERNAME M(M_USERNAME) /* shortcut for username */ -#define RANDDIG M(M_RANDDIGIT) -#define RANDALP M(M_RANDLETTER) -#define CTLENTER MT(MOD_RCTL, KC_ENT) -#define SHIFTQUOTE MT(MOD_RSFT, KC_QUOT) -#define ALTRIGHT MT(MOD_LALT, KC_RGHT) -#define MVERSION M(M_VERSION) -#define ALTSLASH LALT(KC_SLSH) - - -/* Note that Planck has dimensions 4 rows x 12 columns */ - -const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { -[_QWERTY] = LAYOUT_planck_grid( /* Qwerty */ - KC_ESC, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC, - KC_LCTL, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, CTLENTER, - KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, SHIFTQUOTE , - KC_TAB, KC_LALT, ROT_LED, KC_LGUI, M_LOWER, KC_SPC, KC_SPC, M_UPPER, KC_LEFT, KC_DOWN, KC_UP, ALTRIGHT - /* Note that KC_SPC is recorded TWICE, so that either matrix position can activate it */ -), -[_RAISE] = LAYOUT_planck_grid( /* RAISE */ - KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_BSPC, - _______, KC_4, KC_5, KC_6, _______, _______, _______, KC_MINS, KC_EQL, KC_LBRC, KC_RBRC, KC_BSLS, - _______, KC_7, KC_8, KC_9, _______, _______, _______, QWERTY, KEYPAD, KEYPAD, ALTSLASH,_______, - _______, KC_0, _______, _______, _______, _______, _______, _______, KC_PGDN, KC_HOME, KC_END, KC_PGUP -), -[_LOWER] = LAYOUT_planck_grid( /* LOWER */ - KC_TILD, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, KC_BSPC, - _______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_UNDS, KC_PLUS, KC_LCBR, KC_RCBR, KC_PIPE, - _______, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, QWERTY, KEYPAD, KEYPAD, ALTSLASH, _______, - _______, KEYPAD, _______, _______, _______, _______, _______, _______, KC_PGDN, KC_HOME, KC_END, KC_PGUP - ), -[_KEYPAD] = LAYOUT_planck_grid( /* Key Pad */ - KC_ESC, USERNAME, MVERSION, KC_F10, KC_F11, KC_F12, KC_PGUP, KC_KP_ENTER, KC_7, KC_8, KC_9, KC_BSPC, - KC_LCTL, RANDDIG, KC_F5, KC_F6, KC_F7, KC_F8, KC_PGDN, KC_KP_MINUS, KC_4, KC_5, KC_6, KC_PIPE, - KC_LSFT, RANDALP, KC_F1, KC_F2, KC_F3, KC_F4, KC_DEL, KC_KP_PLUS, KC_1, KC_2, KC_3, KC_ENTER, - KC_TAB, KC_LALT, ROT_LED, KC_LGUI, M_LOWER, KC_SPC, KC_SPC, QWERTY, KC_LEFT, KC_DOWN, KC_UP, KC_RIGHT -), - -[_ADJUST] = LAYOUT_planck_grid( /* Adjustments - gonna shift the wild tools in here */ - ROT_LED,USERNAME,MVERSION, _______, _______, _______, _______, _______, _______, _______, _______, _______ , - _______, RANDDIG, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ , - _______, RANDALP, _______, _______, _______, QK_BOOT, QK_BOOT, _______, _______, _______, _______, _______ , - _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ -) -}; - -/* This bit of logic seeds a wee linear congruential random number generator */ -/* lots of prime numbers everywhere... */ -static uint16_t random_value = 157; - -const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt) -{ - uint8_t clockbyte=0; - clockbyte = TCNT1 % 256; - uint8_t rval; - // MACRODOWN only works in this function - switch(id) { - case M_LED: - if (record->event.pressed) { - register_code(KC_RSFT); -#ifdef BACKLIGHT_ENABLE - backlight_step(); -#endif - } else { - unregister_code(KC_RSFT); - } - break; - case M_USERNAME: - if (record->event.pressed) { - SEND_STRING("cbbrowne"); - } - break; - case M_VERSION: - if (record->event.pressed) { - SEND_STRING(QMK_KEYBOARD "/" QMK_KEYMAP "@" QMK_VERSION "@" QMK_BUILDDATE); - } - break; - case M_RANDDIGIT: - /* Generate, based on random number generator, a keystroke for - a numeric digit chosen at random */ - random_value = ((random_value + randadd) * randmul) % randmod; - if (record->event.pressed) { - /* Here, we mix the LCRNG with low bits from one of the system - clocks via XOR in the theory that this may be more random - than either separately */ - rval = (random_value ^ clockbyte) % 10; - /* Note that KC_1 thru KC_0 are a contiguous range */ - register_code (KC_1 + rval); - unregister_code (KC_1 + rval); - } - break; - case M_RANDLETTER: - /* Generate, based on random number generator, a keystroke for - a letter chosen at random */ - /* Here, we mix the LCRNG with low bits from one of the system - clocks via XOR in the theory that this may be more random - than either separately */ - random_value = ((random_value + randadd) * randmul) % randmod; - if (record->event.pressed) { - rval = (random_value ^ clockbyte) % 26; - register_code (KC_A + rval); - unregister_code (KC_A + rval); - } - break; - case MACRO_UPPER: - if (record->event.pressed) - { - layer_on(_RAISE); -#ifdef BACKLIGHT_BREATHING - breathing_period_set(2); - breathing_pulse(); -#endif - update_tri_layer(_LOWER, _RAISE, _ADJUST); - } - else - { - layer_off(_RAISE); - update_tri_layer(_LOWER, _RAISE, _ADJUST); - } - break; - case MACRO_LOWER: - if (record->event.pressed) - { - layer_on(_LOWER); -#ifdef BACKLIGHT_BREATHING - breathing_period_set(2); - breathing_pulse(); -#endif - update_tri_layer(_LOWER, _RAISE, _ADJUST); - } - else - { - layer_off(_LOWER); - update_tri_layer(_LOWER, _RAISE, _ADJUST); - } - break; - - } - return MACRO_NONE; -}; - -void press_key(uint16_t key) { - register_code(key); - unregister_code(key); -} - -void press_two_keys(uint16_t key1, uint16_t key2) { - register_code(key1); - register_code(key2); - unregister_code(key2); - unregister_code(key1); -} - -void press_three_keys(uint16_t key1, uint16_t key2, uint16_t key3) { - register_code(key1); - register_code(key2); - register_code(key3); - unregister_code(key3); - unregister_code(key2); - unregister_code(key1); -} - -bool process_record_user(uint16_t keycode, keyrecord_t *record) { - switch (keycode) { - case MY_BELW: - if (record->event.pressed) { - press_two_keys(KC_LGUI, KC_RGHT); - press_key(KC_ENT); - } - - return false; - - case MY_ABVE: - if (record->event.pressed) { - press_two_keys(KC_LGUI, KC_LEFT); - press_key(KC_ENT); - press_key(KC_UP); - } - - return false; - - case MY_TERM: - if (record->event.pressed) { - press_three_keys(KC_LGUI, KC_LSFT, KC_ENT); - } - - return false; - - case MY_DEQL: // /= - if (record->event.pressed) { - press_key(KC_SLSH); - press_key(KC_EQL); - } - - return false; - - case MY_MEQL: // *= - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_ASTR); - press_key(KC_EQL); - } - - return false; - - case MY_SEQL: // -= - if (record->event.pressed) { - press_key(KC_MINS); - press_key(KC_EQL); - } - - return false; - - case MY_PEQL: // += - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_PLUS); - press_key(KC_EQL); - } - - return false; - - case MY_NEQL: // != - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_EXLM); - press_key(KC_EQL); - } - - return false; - - case MY_LTGT: // <> - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_LABK); - press_two_keys(KC_LSFT, KC_RABK); - } - - return false; - - case MY_DPIP: // || - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_PIPE); - press_two_keys(KC_LSFT, KC_PIPE); - } - - return false; - - case MY_DAMP: // && - if (record->event.pressed) { - press_two_keys(KC_LSFT, KC_AMPR); - press_two_keys(KC_LSFT, KC_AMPR); - } - - return false; - } - - return true; -} - diff --git a/keyboards/planck/keymaps/cbbrowne/readme.org b/keyboards/planck/keymaps/cbbrowne/readme.org deleted file mode 100644 index 2b10058584..0000000000 --- a/keyboards/planck/keymaps/cbbrowne/readme.org +++ /dev/null @@ -1,117 +0,0 @@ -* cbbrowne custom keyboard - - Due to cbbrowne@acm.org - Christopher Browne - - This was originally based on the default keyboard map, but I have - been doing sundry experimentation: - -** Useful Experiments - - - It made sense to mess around some with keyboard maps. - - I added a keypad, originally based on keymaps/numpad.c, but - mighty substantially revised, as that one seems to be rotated 90 - degrees from usual conventions for number pads - - The keypad layer also includes some sample "hacks" of cool things, - all using actions attached in using the function action_get_macro() - - Key [1][2] aka "q" types out my name, cbbrowne, as a fun example - of a key generating a bunch of keystrokes. The keystroke is - sufficiently inconvenient that it isn't terribly practical for me - to use it, but hey, it shows how others might use this facility - in a more useful context. - - Key [2][2] aka "a" uses a random number generator to select a digit 0-9 at random - - Key [3][2] aka "z" uses a random number generator to select a letter a-z at random - - Key [1][3] aka "e" spits out the keymap version number - - Trying out sgoodwin's "hold Enter down to get Shift" - - Liking this Quite Well Enough... - - Applied this to both Shift and Quote - - It seems likely that Alt should get a right-hand-side, akin to this... - - Alt needs to move, and get a RHS - - Hence ALTRIGHT, and shifted ROT_LED over - - Emacs likes this!!! :-) - - I'm suspicious that I'll want to shift ROT_LED another location over, - so some modifier can replace the OS/KC_LGUI key - - I have added an alternate ADJUST layer that is activated via update_tri_layer() - - e.g. - LOWER+RAISE simultaneously - - This seems entirely more useful for handling my "special keys" - like the random numbers, user name, and such, than the keypad layer - - The _ADJUST layer provides a good place to have RESET - - But this isn't strictly enough; I want RESET somewhat accessible from - main layer lest an error hide that layer - - I never use the OS/KC_LGUI key (that's Command on MacOS, Windows - Key on Windows), so that's a good place to have it as a chord of - some sort - - -** Some code structure ideas - - Each layer is given a name to aid in readability, which is then - used in the keymap matrix below. The underscores do not denote - anything - you can have a layer called STUFF or any other name. - - Layer names don't all need to be of the same length, obviously, and - you could also skip them entirely and just use numbers, though that - means needing to manage the numbers. - - It is preferable to keep the symbols short so that a line worth of - key mappings fits compactly onto a line of code. It might be an - interesting idea to express the maps rotated 90%, so that you - only need to fit 4 symbols onto each line, rather than 12. - - I use enums to manage layer IDs and macro IDs so that I don't need - to care (beyond "start at 0", and arguably even that's not needed) - about their values. - -** Things I did not like about the default mapping - - - - I found control too hard to get to. I use it more than Tab, so - switched it there. - - Having dash on [lower-j] is a bit nonintuitive, but may be OK - - I switched ESC/TAB/M(0) around - - I'm suspicious that I want to shift M(0) from [4][1] to [4][2], - and shift ESC off the first column so KC_LCTL and KC_LALT can - be on the first column. - - I needed to swap ' and ENTER - -** Unuseful experiments - -I have tried some things out that didn't turn out particularly well. -I'll note some of these for posterity, hopefully helpful in not doing -unwise things again... - - - I tried added Workman alongside Dvorak and Colemak - - Boy, oh boy, these don't help!!! - - I have done 30 years of learning of Emacs key mappings, and - these alternative keyboards massively mess me up - - - Space Cadet Shift; switching L_SHIFT to KC_LSP0, so that when I - just hit SHIFT, I get a left parens. In principle, this is great - for Lisping. - - Unfortunately, there are times when mouse interfaces use SHIFT - to allow selecting multiple items, and this really interferes - with that - -** TODO - - - I use tmux quite a lot; the mollat keymap seems to have some - interesting helpers. It might be interesting to add a "tmux - layer," or to have a few keys in a layer oriented towards that - - Keys for... - - Picking windows 0 thru 8 - - next/prev/new window - - The mollat tmux layer also suggests some thoughts about Emacs - helpers. - - I do not presently have anything that handles X11 screen - switching, as with Control-Alt-various - - I ought to probably look into KC_LEAD, to have some key combos - that do not need to be concurrent - - The jeebak keymap seems to have some neat ideas: - - Number layer which is aggressive about having numbers in several places - - TouchCursor layer seems interesting - - It sets up a layer with cursor keys on the home keys - - The jeremy-dev keymap has some very interesting concepts - - Shift hands outwards; the special keys go in the center - - Symbol layer has some compound keys for C operators like /=, *=, -=, +=, ... - - This is likely what I'll use for my XD75re, and maybe I'll fork a - planck keymap for similar diff --git a/keyboards/planck/keymaps/cbbrowne/rules.mk b/keyboards/planck/keymaps/cbbrowne/rules.mk deleted file mode 100644 index 13c2530dd4..0000000000 --- a/keyboards/planck/keymaps/cbbrowne/rules.mk +++ /dev/null @@ -1,20 +0,0 @@ -# Build Options -# change to "no" to disable the options, or define them in the Makefile in -# the appropriate keymap folder that will get included automatically -# -BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite -MOUSEKEY_ENABLE = no # Mouse keys(+4700) -EXTRAKEY_ENABLE = no # Audio control and System control(+450) -CONSOLE_ENABLE = no # Console for debug(+400) -COMMAND_ENABLE = yes # Commands for debug and configuration -NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work -BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -MIDI_ENABLE = no # MIDI controls -AUDIO_ENABLE = no # Audio output on port C6 -UNICODE_ENABLE = no # Unicode -BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID -RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. - -# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE -SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend - -- cgit v1.2.3