From 1022afa6c24a64c78d1c9be99a695ff5335876f7 Mon Sep 17 00:00:00 2001 From: Ryan Date: Sat, 11 Mar 2023 04:59:07 +1100 Subject: Move matrix config to info.json, part 8 (#20030) --- keyboards/knobgoblin/config.h | 8 -------- keyboards/knobgoblin/info.json | 5 +++++ 2 files changed, 5 insertions(+), 8 deletions(-) (limited to 'keyboards/knobgoblin') diff --git a/keyboards/knobgoblin/config.h b/keyboards/knobgoblin/config.h index 435c727db5..101faa7619 100644 --- a/keyboards/knobgoblin/config.h +++ b/keyboards/knobgoblin/config.h @@ -16,12 +16,4 @@ #pragma once - -/* key matrix pins */ -#define MATRIX_ROW_PINS { D4, B6, B2, B3, B1 } -#define MATRIX_COL_PINS { B5, B4, E6, D7, C6 } - #define OLED_TIMEOUT 180000 - -/* COL2ROW or ROW2COL */ -#define DIODE_DIRECTION COL2ROW diff --git a/keyboards/knobgoblin/info.json b/keyboards/knobgoblin/info.json index c0d8de34e9..b17c1077cc 100644 --- a/keyboards/knobgoblin/info.json +++ b/keyboards/knobgoblin/info.json @@ -8,6 +8,11 @@ "pid": "0x0000", "device_version": "0.0.1" }, + "matrix_pins": { + "cols": ["B5", "B4", "E6", "D7", "C6"], + "rows": ["D4", "B6", "B2", "B3", "B1"] + }, + "diode_direction": "COL2ROW", "encoder": { "rotary": [ {"pin_a": "F7", "pin_b": "F6"}, -- cgit v1.2.3 From f111bea3cda240b7c54bff2e12b5043b7b0797f7 Mon Sep 17 00:00:00 2001 From: Ryan Date: Tue, 25 Apr 2023 02:38:35 +1000 Subject: Move miscellaneous layouts to data driven (#20516) --- keyboards/knobgoblin/info.json | 47 +++++++++++++++++++-------------------- keyboards/knobgoblin/knobgoblin.c | 2 +- keyboards/knobgoblin/knobgoblin.h | 32 -------------------------- 3 files changed, 24 insertions(+), 57 deletions(-) delete mode 100644 keyboards/knobgoblin/knobgoblin.h (limited to 'keyboards/knobgoblin') diff --git a/keyboards/knobgoblin/info.json b/keyboards/knobgoblin/info.json index b17c1077cc..e3f2d93e15 100644 --- a/keyboards/knobgoblin/info.json +++ b/keyboards/knobgoblin/info.json @@ -28,35 +28,34 @@ "layouts": { "LAYOUT_ortho": { "layout": [ - - {"label": "F17", "x": 1, "y": 0}, - {"label": "F18", "x": 2, "y": 0}, - {"label": "F19", "x": 3, "y": 0}, - {"label": "F20", "x": 4, "y": 0}, + {"matrix": [0, 1], "x": 1, "y": 0}, + {"matrix": [0, 2], "x": 2, "y": 0}, + {"matrix": [0, 3], "x": 3, "y": 0}, + {"matrix": [0, 4], "x": 4, "y": 0}, - {"label": "F13", "x": 1, "y": 1}, - {"label": "F14", "x": 2, "y": 1}, - {"label": "F15", "x": 3, "y": 1}, - {"label": "F16", "x": 4, "y": 1}, + {"matrix": [1, 1], "x": 1, "y": 1}, + {"matrix": [1, 2], "x": 2, "y": 1}, + {"matrix": [1, 3], "x": 3, "y": 1}, + {"matrix": [1, 4], "x": 4, "y": 1}, - {"label": "F9", "x": 1, "y": 2}, - {"label": "F10", "x": 2, "y": 2}, - {"label": "F11", "x": 3, "y": 2}, - {"label": "F12", "x": 4, "y": 2}, + {"matrix": [2, 1], "x": 1, "y": 2}, + {"matrix": [2, 2], "x": 2, "y": 2}, + {"matrix": [2, 3], "x": 3, "y": 2}, + {"matrix": [2, 4], "x": 4, "y": 2}, - {"label": "K2", "x": 0, "y": 3}, - {"label": "F5", "x": 1, "y": 3}, - {"label": "F6", "x": 2, "y": 3}, - {"label": "F7", "x": 3, "y": 3}, - {"label": "F8", "x": 4, "y": 3}, - - {"label": "K1", "x": 0, "y": 4}, - {"label": "F1", "x": 1, "y": 4}, - {"label": "F2", "x": 2, "y": 4}, - {"label": "F3", "x": 3, "y": 4}, - {"label": "F4", "x": 4, "y": 4} + {"matrix": [3, 0], "x": 0, "y": 3}, + {"matrix": [3, 1], "x": 1, "y": 3}, + {"matrix": [3, 2], "x": 2, "y": 3}, + {"matrix": [3, 3], "x": 3, "y": 3}, + {"matrix": [3, 4], "x": 4, "y": 3}, + {"matrix": [4, 0], "x": 0, "y": 4}, + {"matrix": [4, 1], "x": 1, "y": 4}, + {"matrix": [4, 2], "x": 2, "y": 4}, + {"matrix": [4, 3], "x": 3, "y": 4}, + {"matrix": [4, 4], "x": 4, "y": 4} ] } } + } diff --git a/keyboards/knobgoblin/knobgoblin.c b/keyboards/knobgoblin/knobgoblin.c index fcf86a3a40..55112847df 100644 --- a/keyboards/knobgoblin/knobgoblin.c +++ b/keyboards/knobgoblin/knobgoblin.c @@ -14,7 +14,7 @@ * along with this program. If not, see . */ -#include "knobgoblin.h" +#include "quantum.h" #ifdef ENCODER_ENABLE /* assign keycodes to the encoder rotation */ diff --git a/keyboards/knobgoblin/knobgoblin.h b/keyboards/knobgoblin/knobgoblin.h deleted file mode 100644 index b5b2cf7e5f..0000000000 --- a/keyboards/knobgoblin/knobgoblin.h +++ /dev/null @@ -1,32 +0,0 @@ -/* Copyright 2020 MrT1ddl3s - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation, either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ - -#pragma once -#include "quantum.h" - -#define LAYOUT_ortho( \ - K01, K02, K03, K04, \ - K11, K12, K13, K14, \ - K21, K22, K23, K24, \ - K30, K31, K32, K33, K34, \ - K40, K41, K42, K43, K44 \ -) { \ - { KC_NO, K01, K02, K03, K04 }, \ - { KC_NO, K11, K12, K13, K14 }, \ - { KC_NO, K21, K22, K23, K24 }, \ - { K30, K31, K32, K33, K34 }, \ - { K40, K41, K42, K43, K44 } \ -} -- cgit v1.2.3 From 79aa31994698c9050141714f77c0177edbcd9488 Mon Sep 17 00:00:00 2001 From: Ryan Date: Tue, 2 May 2023 08:25:15 +1000 Subject: `info.json` whitespace cleanups (#20651) --- keyboards/knobgoblin/info.json | 1 - 1 file changed, 1 deletion(-) (limited to 'keyboards/knobgoblin') diff --git a/keyboards/knobgoblin/info.json b/keyboards/knobgoblin/info.json index e3f2d93e15..bdf826777d 100644 --- a/keyboards/knobgoblin/info.json +++ b/keyboards/knobgoblin/info.json @@ -57,5 +57,4 @@ ] } } - } -- cgit v1.2.3