From 4a66bdf29443607ae01c1a6c87b657f89d3a1769 Mon Sep 17 00:00:00 2001 From: Takeshi ISHII <2170248+mtei@users.noreply.github.com> Date: Fri, 4 Mar 2022 05:23:49 +0900 Subject: Fix helix/rev2 not working properly when using split_common. (#16512) When helix/rev2 was using split_common, it didn't work properly and I couldn't type on the right hand side. The cause is that the following code, added in 0.16.0 to `quantum/keyboard.c`, does not include `quantum/split_common/split_util.h` but instead includes `keyboards/helix/rev2/split_util.h`. Therefore, `split_pre_init()/split_post_init()` in `quantum/split_common/split_util.c` was not called. ```c #ifdef SPLIT_KEYBOARD # include "split_util.h" #endif ``` --- keyboards/helix/rev2/split_util.h | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 keyboards/helix/rev2/split_util.h (limited to 'keyboards/helix/rev2/split_util.h') diff --git a/keyboards/helix/rev2/split_util.h b/keyboards/helix/rev2/split_util.h deleted file mode 100644 index 535949118a..0000000000 --- a/keyboards/helix/rev2/split_util.h +++ /dev/null @@ -1,20 +0,0 @@ -#pragma once - -#include -#include "eeconfig.h" - -#define SLAVE_I2C_ADDRESS 0x32 - -extern volatile bool isLeftHand; - -// slave version of matix scan, defined in matrix.c -void matrix_slave_scan(void); - -void split_keyboard_setup(void); -bool is_helix_master(void); - -void matrix_master_OLED_init (void); - -// stubs as this is handled by legacy code -static inline void split_pre_init(void){} -static inline void split_post_init(void){} -- cgit v1.2.3