From 8136cf4bfb2664a0a492f7346132afc78110cce0 Mon Sep 17 00:00:00 2001
From: Ryan <fauxpark@gmail.com>
Date: Fri, 10 Nov 2023 08:39:15 +1100
Subject: LED drivers: clean up `SWx`/`CSy` pullup/down resistor config
 (#22381)

---
 drivers/led/issi/is31fl3741-simple.h | 45 +++++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 18 deletions(-)

(limited to 'drivers/led/issi/is31fl3741-simple.h')

diff --git a/drivers/led/issi/is31fl3741-simple.h b/drivers/led/issi/is31fl3741-simple.h
index d022f3a865..b8cda3da34 100644
--- a/drivers/led/issi/is31fl3741-simple.h
+++ b/drivers/led/issi/is31fl3741-simple.h
@@ -38,23 +38,23 @@
 #    define IS31FL3741_CONFIGURATION ISSI_CONFIGURATION
 #endif
 #ifdef ISSI_SWPULLUP
-#    define IS31FL3741_SWPULLUP ISSI_SWPULLUP
+#    define IS31FL3741_SW_PULLUP ISSI_SWPULLUP
 #endif
 #ifdef ISSI_CSPULLUP
-#    define IS31FL3741_CSPULLUP ISSI_CSPULLUP
+#    define IS31FL3741_CS_PULLDOWN ISSI_CSPULLUP
 #endif
 #ifdef ISSI_GLOBALCURRENT
 #    define IS31FL3741_GLOBALCURRENT ISSI_GLOBALCURRENT
 #endif
 
-#define PUR_0R IS31FL3741_PUR_0R
-#define PUR_05KR IS31FL3741_PUR_05KR
-#define PUR_1KR IS31FL3741_PUR_1KR
-#define PUR_2KR IS31FL3741_PUR_2KR
-#define PUR_4KR IS31FL3741_PUR_4KR
-#define PUR_8KR IS31FL3741_PUR_8KR
-#define PUR_16KR IS31FL3741_PUR_16KR
-#define PUR_32KR IS31FL3741_PUR_32KR
+#define PUR_0R IS31FL3741_PUR_0_OHM
+#define PUR_05KR IS31FL3741_PUR_0K5_OHM
+#define PUR_1KR IS31FL3741_PUR_1K_OHM
+#define PUR_2KR IS31FL3741_PUR_2K_OHM
+#define PUR_4KR IS31FL3741_PUR_4K_OHM
+#define PUR_8KR IS31FL3741_PUR_8K_OHM
+#define PUR_16KR IS31FL3741_PUR_16K_OHM
+#define PUR_32KR IS31FL3741_PUR_32K_OHM
 // ========
 
 #define IS31FL3741_I2C_ADDRESS_GND 0x30
@@ -95,14 +95,23 @@ void is31fl3741_set_pwm_buffer(const is31fl3741_led *pled, uint8_t value);
 
 void is31fl3741_flush(void);
 
-#define IS31FL3741_PUR_0R 0x00   // No PUR resistor
-#define IS31FL3741_PUR_05KR 0x01 // 0.5k Ohm resistor
-#define IS31FL3741_PUR_1KR 0x02  // 1.0k Ohm resistor
-#define IS31FL3741_PUR_2KR 0x03  // 2.0k Ohm resistor
-#define IS31FL3741_PUR_4KR 0x04  // 4.0k Ohm resistor
-#define IS31FL3741_PUR_8KR 0x05  // 8.0k Ohm resistor
-#define IS31FL3741_PUR_16KR 0x06 // 16k Ohm resistor
-#define IS31FL3741_PUR_32KR 0x07 // 32k Ohm resistor
+#define IS31FL3741_PDR_0_OHM 0b000   // No pull-down resistor
+#define IS31FL3741_PDR_0K5_OHM 0b001 // 0.5 kOhm resistor
+#define IS31FL3741_PDR_1K_OHM 0b010  // 1 kOhm resistor
+#define IS31FL3741_PDR_2K_OHM 0b011  // 2 kOhm resistor
+#define IS31FL3741_PDR_4K_OHM 0b100  // 4 kOhm resistor
+#define IS31FL3741_PDR_8K_OHM 0b101  // 8 kOhm resistor
+#define IS31FL3741_PDR_16K_OHM 0b110 // 16 kOhm resistor
+#define IS31FL3741_PDR_32K_OHM 0b111 // 32 kOhm resistor
+
+#define IS31FL3741_PUR_0_OHM 0b000   // No pull-up resistor
+#define IS31FL3741_PUR_0K5_OHM 0b001 // 0.5 kOhm resistor
+#define IS31FL3741_PUR_1K_OHM 0b010  // 1 kOhm resistor
+#define IS31FL3741_PUR_2K_OHM 0b011  // 2 kOhm resistor
+#define IS31FL3741_PUR_4K_OHM 0b100  // 4 kOhm resistor
+#define IS31FL3741_PUR_8K_OHM 0b101  // 8 kOhm resistor
+#define IS31FL3741_PUR_16K_OHM 0b110 // 16 kOhm resistor
+#define IS31FL3741_PUR_32K_OHM 0b111 // 32 kOhm resistor
 
 #define IS31FL3741_PWM_FREQUENCY_29K_HZ 0b0000
 #define IS31FL3741_PWM_FREQUENCY_3K6_HZ 0b0011
-- 
cgit v1.2.3