From 8136cf4bfb2664a0a492f7346132afc78110cce0 Mon Sep 17 00:00:00 2001
From: Ryan <fauxpark@gmail.com>
Date: Fri, 10 Nov 2023 08:39:15 +1100
Subject: LED drivers: clean up `SWx`/`CSy` pullup/down resistor config
 (#22381)

---
 drivers/led/issi/is31fl3733-simple.h | 42 ++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 16 deletions(-)

(limited to 'drivers/led/issi/is31fl3733-simple.h')

diff --git a/drivers/led/issi/is31fl3733-simple.h b/drivers/led/issi/is31fl3733-simple.h
index 65d3298a50..2c6014455f 100644
--- a/drivers/led/issi/is31fl3733-simple.h
+++ b/drivers/led/issi/is31fl3733-simple.h
@@ -39,10 +39,10 @@
 #    define IS31FL3733_PWM_FREQUENCY ISSI_PWM_FREQUENCY
 #endif
 #ifdef ISSI_SWPULLUP
-#    define IS31FL3733_SWPULLUP ISSI_SWPULLUP
+#    define IS31FL3733_SW_PULLUP ISSI_SWPULLUP
 #endif
 #ifdef ISSI_CSPULLUP
-#    define IS31FL3733_CSPULLUP ISSI_CSPULLUP
+#    define IS31FL3733_CS_PULLDOWN ISSI_CSPULLUP
 #endif
 #ifdef ISSI_GLOBALCURRENT
 #    define IS31FL3733_GLOBALCURRENT ISSI_GLOBALCURRENT
@@ -51,13 +51,13 @@
 #define is31_led is31fl3733_led_t
 #define g_is31_leds g_is31fl3733_leds
 
-#define PUR_0R IS31FL3733_PUR_0R
-#define PUR_05KR IS31FL3733_PUR_05KR
-#define PUR_3KR IS31FL3733_PUR_3KR
-#define PUR_4KR IS31FL3733_PUR_4KR
-#define PUR_8KR IS31FL3733_PUR_8KR
-#define PUR_16KR IS31FL3733_PUR_16KR
-#define PUR_32KR IS31FL3733_PUR_32KR
+#define PUR_0R IS31FL3733_PUR_0_OHM
+#define PUR_05KR IS31FL3733_PUR_1K_OHM
+#define PUR_3KR IS31FL3733_PUR_2K_OHM
+#define PUR_4KR IS31FL3733_PUR_4K_OHM
+#define PUR_8KR IS31FL3733_PUR_8K_OHM
+#define PUR_16KR IS31FL3733_PUR_16K_OHM
+#define PUR_32KR IS31FL3733_PUR_32K_OHM
 // ========
 
 #define IS31FL3733_I2C_ADDRESS_GND_GND 0x50
@@ -107,13 +107,23 @@ void is31fl3733_update_led_control_registers(uint8_t addr, uint8_t index);
 
 void is31fl3733_flush(void);
 
-#define IS31FL3733_PUR_0R 0x00   // No PUR resistor
-#define IS31FL3733_PUR_05KR 0x02 // 0.5k Ohm resistor in t_NOL
-#define IS31FL3733_PUR_3KR 0x03  // 3.0k Ohm resistor on all the time
-#define IS31FL3733_PUR_4KR 0x04  // 4.0k Ohm resistor on all the time
-#define IS31FL3733_PUR_8KR 0x05  // 8.0k Ohm resistor on all the time
-#define IS31FL3733_PUR_16KR 0x06 // 16k Ohm resistor on all the time
-#define IS31FL3733_PUR_32KR 0x07 // 32k Ohm resistor in t_NOL
+#define IS31FL3733_PDR_0_OHM 0b000   // No pull-down resistor
+#define IS31FL3733_PDR_0K5_OHM 0b001 // 0.5 kOhm resistor
+#define IS31FL3733_PDR_1K_OHM 0b010  // 1 kOhm resistor
+#define IS31FL3733_PDR_2K_OHM 0b011  // 2 kOhm resistor
+#define IS31FL3733_PDR_4K_OHM 0b100  // 4 kOhm resistor
+#define IS31FL3733_PDR_8K_OHM 0b101  // 8 kOhm resistor
+#define IS31FL3733_PDR_16K_OHM 0b110 // 16 kOhm resistor
+#define IS31FL3733_PDR_32K_OHM 0b111 // 32 kOhm resistor
+
+#define IS31FL3733_PUR_0_OHM 0b000   // No pull-up resistor
+#define IS31FL3733_PUR_0K5_OHM 0b001 // 0.5 kOhm resistor
+#define IS31FL3733_PUR_1K_OHM 0b010  // 1 kOhm resistor
+#define IS31FL3733_PUR_2K_OHM 0b011  // 2 kOhm resistor
+#define IS31FL3733_PUR_4K_OHM 0b100  // 4 kOhm resistor
+#define IS31FL3733_PUR_8K_OHM 0b101  // 8 kOhm resistor
+#define IS31FL3733_PUR_16K_OHM 0b110 // 16 kOhm resistor
+#define IS31FL3733_PUR_32K_OHM 0b111 // 32 kOhm resistor
 
 #define IS31FL3733_PWM_FREQUENCY_8K4_HZ 0b000
 #define IS31FL3733_PWM_FREQUENCY_4K2_HZ 0b001
-- 
cgit v1.2.3