From 4d116a04e94cf0d19317d5b44e4fa9f34a3e5594 Mon Sep 17 00:00:00 2001 From: tmk Date: Tue, 28 Apr 2015 11:27:10 +0900 Subject: Squashed 'tmk_core/' changes from b9e0ea0..caca2c0 caca2c0 Add mouse support to ADB 5b0835a Merge commit '1fe4406f374291ab2e86e95a97341fd9c475fcb8' f2f7556 Remove unneeded tap delays #201 8124195 Fix URL of HID Usage Tables pdf 0bb4679 Fix typo of doc/keycode.txt b24fa1a Fix handling of consumer usage #199 6ae1a3d Improve anti-ghosting behavior for fast typing a4c9763 Fix dfu-programmer parameters b62b3f2 Move ring_buffer.h file 6ec424f Fix debug print 502fb0c Fix ibm4704 protocol with using interrupt git-subtree-dir: tmk_core git-subtree-split: caca2c01553394d959550034c817520d575c7fa0 --- common/action.c | 7 ++++++- common/action_code.h | 14 +++++++------- common/keyboard.c | 25 +++++++++++++++++++++++-- common/keymap.c | 2 +- 4 files changed, 37 insertions(+), 11 deletions(-) (limited to 'common') diff --git a/common/action.c b/common/action.c index ec8eeae7bc..1f15bd0918 100644 --- a/common/action.c +++ b/common/action.c @@ -518,7 +518,12 @@ bool is_tap_key(keypos_t key) case ACT_RMODS_TAP: case ACT_LAYER_TAP: case ACT_LAYER_TAP_EXT: - return true; + switch (action.layer_tap.code) { + case 0x00 ... 0xdf: + case OP_TAP_TOGGLE: + return true; + } + return false; case ACT_MACRO: case ACT_FUNCTION: if (action.func.opt & FUNC_TAP) { return true; } diff --git a/common/action_code.h b/common/action_code.h index bc40e2c6fb..32ef07216d 100644 --- a/common/action_code.h +++ b/common/action_code.h @@ -70,13 +70,13 @@ along with this program. If not, see . * 1001|oopp|BBBB BBBB 8-bit Bitwise Operation??? * * ACT_LAYER_TAP(101x): - * 101E|LLLL| keycode On/Off with tap key - * 101E|LLLL|1110 mods On/Off with modifiers(0xE0-EF) - * 101E|LLLL|1111 0000 Invert with tap toggle(0xF0) - * 101E|LLLL|1111 0001 On/Off - * 101E|LLLL|1111 0010 Off/On - * 101E|LLLL|1111 0011 Set/Clear - * 101E|LLLL|1111 xxxx Reserved(0xF4-FF) + * 101E|LLLL| keycode On/Off with tap key (0x00-DF)[TAP] + * 101E|LLLL|1110 mods On/Off with modifiers (0xE0-EF)[NOT TAP] + * 101E|LLLL|1111 0000 Invert with tap toggle (0xF0) [TAP] + * 101E|LLLL|1111 0001 On/Off (0xF1) [NOT TAP] + * 101E|LLLL|1111 0010 Off/On (0xF2) [NOT TAP] + * 101E|LLLL|1111 0011 Set/Clear (0xF3) [NOT TAP] + * 101E|LLLL|1111 xxxx Reserved (0xF4-FF) * ELLLL: layer 0-31(E: extra bit for layer 16-31) * * diff --git a/common/keyboard.c b/common/keyboard.c index 1e3fb510a4..b03b124d76 100644 --- a/common/keyboard.c +++ b/common/keyboard.c @@ -39,6 +39,9 @@ along with this program. If not, see . #ifdef SERIAL_MOUSE_ENABLE #include "serial_mouse.h" #endif +#ifdef ADB_MOUSE_ENABLE +#include "adb.h" +#endif #ifdef MATRIX_HAS_GHOST @@ -69,6 +72,9 @@ void keyboard_init(void) #ifdef SERIAL_MOUSE_ENABLE serial_mouse_init(); #endif +#ifdef ADB_MOUSE_ENABLE + adb_mouse_init(); +#endif #ifdef BOOTMAGIC_ENABLE @@ -87,6 +93,9 @@ void keyboard_init(void) void keyboard_task(void) { static matrix_row_t matrix_prev[MATRIX_ROWS]; +#ifdef MATRIX_HAS_GHOST + static matrix_row_t matrix_ghost[MATRIX_ROWS]; +#endif static uint8_t led_status = 0; matrix_row_t matrix_row = 0; matrix_row_t matrix_change = 0; @@ -96,13 +105,21 @@ void keyboard_task(void) matrix_row = matrix_get_row(r); matrix_change = matrix_row ^ matrix_prev[r]; if (matrix_change) { - if (debug_matrix) matrix_print(); #ifdef MATRIX_HAS_GHOST if (has_ghost_in_row(r)) { - matrix_prev[r] = matrix_row; + /* Keep track of whether ghosted status has changed for + * debugging. But don't update matrix_prev until un-ghosted, or + * the last key would be lost. + */ + if (debug_matrix && matrix_ghost[r] != matrix_row) { + matrix_print(); + } + matrix_ghost[r] = matrix_row; continue; } + matrix_ghost[r] = matrix_row; #endif + if (debug_matrix) matrix_print(); for (uint8_t c = 0; c < MATRIX_COLS; c++) { if (matrix_change & ((matrix_row_t)1<