summaryrefslogtreecommitdiff
path: root/quantum/process_keycode/process_combo.h
AgeCommit message (Collapse)Author
2019-04-08Switch process_combo to using global register and timer (#2561)Bob
Since combos keep local state about what keys have been previously pressed, when combos are layered, multiple keypresses will register for any key with multiple combos assigned to it. In order to fix this, I switched process_combo to use a global keycode / keyrecord register and timer. When a keypress is consumed by a combo, it gets stored in the register and the timer is updated; when the next keypress takes too long or a key is pressed that isn't part of any combo, the buffer is emitted and the timer reset. This has a few side effects. For instance, I couldn't _not_ fix combo keys printing out of order while also fixing this bug, so combo keys print in order correctly when a combo fails. since combos no longer have local timers, the logic around when combos time out has changed. now that there is a single timer pressing any combo key (including one in a different combo) will reset the timer for all combos, making combo entry a little more lenient. Since combos no longer have local keycode / keyrecord state, there is an edge case where incomplete combo keys can be consumed. if you have a combo for a+s = tab and a combo for b+n = space, if you press a+b+n, only a space will be emitted. This is because when b+n completes successfully, it drops the register.
2018-08-20Fix process_combo which assign -1 to uint16_tShihpin Tseng
2017-03-28Clarify the quantum license (#1042)skullydazed
* Clarify the license for files we have signoff on * Update against the currently signed off files * Remove unused and not clearly licensed headers * Replace an #endif I accidentally removed while resolving merge conflicts
2016-12-16Refactored as well as added support for action keys in combosOfer Plesser
2016-12-10Added support for timing out combos if a key as been pressed for longer than ↵Ofer Plesser
COMBO_TERM
2016-12-10Implemented basic key combination featureOfer Plesser