summaryrefslogtreecommitdiff
path: root/lib/python/qmk/build_targets.py
AgeCommit message (Collapse)Author
2023-11-28QMK Userspace (#22222)Nick Brassel
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
2023-11-22[CLI] Remove duplicates from search results (#22528)Nick Brassel
2023-11-21Fix `qmk find` failure due to circular imports (#22523)Sergey Vlasov
There was an import cycle in the Python modules: - `qmk.build_targets` imported `qmk.cli.generate.compilation_database`; - importing `qmk.cli.generate.compilation_database` requires initializing `qmk.cli` first; - the initialization of `qmk.cli` imported the modules for all CLI commands; - `qmk.cli.compile` imported `qmk.build_targets`. This cycle did not matter in most cases, because `qmk.cli` was imported first, and in that case importing `qmk.cli.generate.compilation_database` did not trigger the initialization of `qmk.cli` again. However, there was one corner case when `qmk.bulld_targets` was getting imported first: - The `qmk find` command uses the `multiprocessing` module. - The `multiprocessing` module uses the `spawn` start method on macOS and Windows. - When the `spawn` method is used, the child processes initialize without any Python modules loaded, and the required modules are loaded on demand by the `pickle` module when receiving the serialized objects from the main process. The result was that the `qmk find` command did not work properly on macOS (and probably Windows too); it reported exceptions like this: ImportError: cannot import name 'KeyboardKeymapBuildTarget' from partially initialized module 'qmk.build_targets' (most likely due to a circular import) Moving the offending `qmk.cli.generate.compilation_database` import into the method which actually uses it fixes the problem.
2023-11-15CLI refactoring for common build target APIs (#22221)Nick Brassel