summaryrefslogtreecommitdiff
path: root/tmk_core
diff options
context:
space:
mode:
authorMichael Tharp <gxti@partiallystapled.com>2014-12-14 12:50:47 -0500
committerJun Wako <wakojun@gmail.com>2015-04-23 16:32:38 +0900
commitb52e29582aa591eb9abbf131981f750de56e3e21 (patch)
treece0d7e48551cf7c98c365b3bd6af851f47a0b8a6 /tmk_core
parentbd24de44b71baa036d30da691f56f34744aa5fd5 (diff)
Improve anti-ghosting behavior for fast typing
Keypresses would be forgotten if they began while ghosting, even if they were still pressed after ghosting ended.
Diffstat (limited to 'tmk_core')
-rw-r--r--tmk_core/common/keyboard.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/tmk_core/common/keyboard.c b/tmk_core/common/keyboard.c
index 1e3fb510a4..f0ead604ec 100644
--- a/tmk_core/common/keyboard.c
+++ b/tmk_core/common/keyboard.c
@@ -87,6 +87,9 @@ void keyboard_init(void)
void keyboard_task(void)
{
static matrix_row_t matrix_prev[MATRIX_ROWS];
+#ifdef MATRIX_HAS_GHOST
+ static matrix_row_t matrix_ghost[MATRIX_ROWS];
+#endif
static uint8_t led_status = 0;
matrix_row_t matrix_row = 0;
matrix_row_t matrix_change = 0;
@@ -96,13 +99,21 @@ void keyboard_task(void)
matrix_row = matrix_get_row(r);
matrix_change = matrix_row ^ matrix_prev[r];
if (matrix_change) {
- if (debug_matrix) matrix_print();
#ifdef MATRIX_HAS_GHOST
if (has_ghost_in_row(r)) {
- matrix_prev[r] = matrix_row;
+ /* Keep track of whether ghosted status has changed for
+ * debugging. But don't update matrix_prev until un-ghosted, or
+ * the last key would be lost.
+ */
+ if (debug_matrix && matrix_ghost[r] != matrix_row) {
+ matrix_print();
+ }
+ matrix_ghost[r] = matrix_row;
continue;
}
+ matrix_ghost[r] = matrix_row;
#endif
+ if (debug_matrix) matrix_print();
for (uint8_t c = 0; c < MATRIX_COLS; c++) {
if (matrix_change & ((matrix_row_t)1<<c)) {
action_exec((keyevent_t){