From 3c58f989295e17d03b66db9a154e02cde7336ece Mon Sep 17 00:00:00 2001 From: Stefan Kerkmann Date: Thu, 14 Jul 2022 11:50:00 +0200 Subject: [Core] PMW33XX drivers overhaul (#17613) * PMW33XX drivers overhaul This combines the PMW3389 and PM3360 drivers as they only differ in the firmware blobs and CPI get and set functions. The following changes have been made: * PMW3389 now gets the same multi-sensor feature that is already available on the PMW3360. * Introduced a shared pmw33xx_report_t struct is now directly readable via SPI transactions instead of individual byte-sized reads, saving multiple copies and bitshift operations. * pmw33(89/60)_get_report functions had unreachable branches in their motion detection logic these have been simplied as much as possible. * The fast firmware upload option has been removed as this becomes obsolete by the newly introduced polled waiting functions for ChibiOS polled waiting * PMW33(60/89)_SPI_LSBFIRST and PMW33(60/89)_SPI_MODE config options have been removed as they don't need to be configurable. * All PMW3389 and PMW3360 defines have been unified to a PMW33XX prefix to reduce code duplication and make the defines interchangeable * Adjust keyboards to PMW33XX naming scheme --- keyboards/oddball/config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'keyboards/oddball') diff --git a/keyboards/oddball/config.h b/keyboards/oddball/config.h index cfb134c4e3..1aaead0cae 100644 --- a/keyboards/oddball/config.h +++ b/keyboards/oddball/config.h @@ -56,4 +56,4 @@ // #define BOOTMAGIC_LITE_COLUMN 0 #define ADNS9800_CS_PIN SPI_SS_PIN -#define PMW3360_CS_PIN SPI_SS_PIN +#define PMW33XX_CS_PIN SPI_SS_PIN -- cgit v1.2.3 From 154d35ac146422bef938ed9756f6e0012baa83a2 Mon Sep 17 00:00:00 2001 From: Nick Brassel Date: Sat, 6 Aug 2022 23:23:35 +1000 Subject: Remove `UNUSED_PINS` (#17931) --- keyboards/oddball/v1/config.h | 1 - keyboards/oddball/v2/config.h | 1 - keyboards/oddball/v2_1/config.h | 1 - 3 files changed, 3 deletions(-) (limited to 'keyboards/oddball') diff --git a/keyboards/oddball/v1/config.h b/keyboards/oddball/v1/config.h index 96aa56f822..7a33a7049a 100644 --- a/keyboards/oddball/v1/config.h +++ b/keyboards/oddball/v1/config.h @@ -28,4 +28,3 @@ */ #define MATRIX_ROW_PINS { F6, B5, B6, F7 } #define MATRIX_COL_PINS { D6, D7, B4, D3, C6, C7 } -#define UNUSED_PINS { B7, D4, D5, E6, F0, F1, F4, F5 } diff --git a/keyboards/oddball/v2/config.h b/keyboards/oddball/v2/config.h index 9ba3bb8dfb..793d305931 100644 --- a/keyboards/oddball/v2/config.h +++ b/keyboards/oddball/v2/config.h @@ -28,4 +28,3 @@ */ #define MATRIX_ROW_PINS { D4, E6, D7, C6 } #define MATRIX_COL_PINS { B7, B5, B4, F5, F6, F7 } -#define UNUSED_PINS { D3, D5, C7, F1, F0, B6, F4 } diff --git a/keyboards/oddball/v2_1/config.h b/keyboards/oddball/v2_1/config.h index 6be3e8a248..9f138d7d52 100644 --- a/keyboards/oddball/v2_1/config.h +++ b/keyboards/oddball/v2_1/config.h @@ -28,4 +28,3 @@ */ #define MATRIX_ROW_PINS { D4, E6, D7, C6 } #define MATRIX_COL_PINS { B6, B5, B4, F5, F6, F7 } -#define UNUSED_PINS { D3, D5, C7, F1, F0, B7, F4 } -- cgit v1.2.3