From ebb512db827e84619e7151fcf76e3daf9328fe59 Mon Sep 17 00:00:00 2001 From: Ryan Date: Sat, 4 Feb 2023 06:19:58 +1100 Subject: Debounce defines cleanup (#19742) * Clean up `DEBOUNCE` in config.h, 0-9 * Clean up `DEBOUNCE` in config.h, A * Clean up `DEBOUNCE` in config.h, B * Clean up `DEBOUNCE` in config.h, C * Clean up `DEBOUNCE` in config.h, D * Clean up `DEBOUNCE` in config.h, E * Clean up `DEBOUNCE` in config.h, F * Clean up `DEBOUNCE` in config.h, G * Clean up `DEBOUNCE` in config.h, H * Clean up `DEBOUNCE` in config.h, handwired * Clean up `DEBOUNCE` in config.h, I * Clean up `DEBOUNCE` in config.h, J * Clean up `DEBOUNCE` in config.h, K * Clean up `DEBOUNCE` in config.h, L * Clean up `DEBOUNCE` in config.h, M * Clean up `DEBOUNCE` in config.h, N * Clean up `DEBOUNCE` in config.h, O * Clean up `DEBOUNCE` in config.h, P * Clean up `DEBOUNCE` in config.h, Q * Clean up `DEBOUNCE` in config.h, R * Clean up `DEBOUNCE` in config.h, S * Clean up `DEBOUNCE` in config.h, T * Clean up `DEBOUNCE` in config.h, U * Clean up `DEBOUNCE` in config.h, V * Clean up `DEBOUNCE` in config.h, W * Clean up `DEBOUNCE` in config.h, X * Clean up `DEBOUNCE` in config.h, Y * Clean up `DEBOUNCE` in config.h, Z * Remove default debounce from info.json * Migrate non-default debounce to info.json --- keyboards/kinesis/kintlc/config.h | 7 ------- keyboards/kinesis/kintlc/info.json | 3 ++- 2 files changed, 2 insertions(+), 8 deletions(-) (limited to 'keyboards/kinesis/kintlc') diff --git a/keyboards/kinesis/kintlc/config.h b/keyboards/kinesis/kintlc/config.h index 4ee9f9ca6f..537cb399d8 100644 --- a/keyboards/kinesis/kintlc/config.h +++ b/keyboards/kinesis/kintlc/config.h @@ -64,13 +64,6 @@ /* COL2ROW or ROW2COL */ #define DIODE_DIRECTION COL2ROW -/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the - * Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce - * algorithm, this debounce latency only affects key releases (not key - * presses). */ -#undef DEBOUNCE -#define DEBOUNCE 20 - #define IGNORE_MOD_TAP_INTERRUPT // The Teensy LC power consumption is unknown as per diff --git a/keyboards/kinesis/kintlc/info.json b/keyboards/kinesis/kintlc/info.json index 721ebbfe82..d937ad902d 100644 --- a/keyboards/kinesis/kintlc/info.json +++ b/keyboards/kinesis/kintlc/info.json @@ -5,5 +5,6 @@ "vid": "0x1209", "pid": "0x345C", "device_version": "0.0.1" - } + }, + "debounce": 20 } -- cgit v1.2.3 From f9aeea64c1f85d388485503e52035b5f7533ed26 Mon Sep 17 00:00:00 2001 From: Ryan Date: Wed, 8 Feb 2023 18:41:46 +1100 Subject: Migrate `MCU` and `BOOTLOADER` to data-driven (#19529) --- keyboards/kinesis/kintlc/info.json | 2 ++ keyboards/kinesis/kintlc/rules.mk | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'keyboards/kinesis/kintlc') diff --git a/keyboards/kinesis/kintlc/info.json b/keyboards/kinesis/kintlc/info.json index d937ad902d..d05b01ec09 100644 --- a/keyboards/kinesis/kintlc/info.json +++ b/keyboards/kinesis/kintlc/info.json @@ -6,5 +6,7 @@ "pid": "0x345C", "device_version": "0.0.1" }, + "processor": "MKL26Z64", + "bootloader": "halfkay", "debounce": 20 } diff --git a/keyboards/kinesis/kintlc/rules.mk b/keyboards/kinesis/kintlc/rules.mk index bfc10748ab..a6a1eafbfc 100644 --- a/keyboards/kinesis/kintlc/rules.mk +++ b/keyboards/kinesis/kintlc/rules.mk @@ -1,5 +1,3 @@ -# MCU name -MCU = MKL26Z64 # This MCU is not in the main CHIBIOS repo but in the CHIBIOS_CONTRIB repo. USE_CHIBIOS_CONTRIB = yes -- cgit v1.2.3 From f4ba17c4a0ee59603c167b04f2d6f6eee8b2cf1b Mon Sep 17 00:00:00 2001 From: Ryan Date: Fri, 17 Feb 2023 13:14:29 +1100 Subject: Move LED indicator config to data driven (#19800) --- keyboards/kinesis/kintlc/config.h | 14 -------------- keyboards/kinesis/kintlc/info.json | 6 ++++++ 2 files changed, 6 insertions(+), 14 deletions(-) (limited to 'keyboards/kinesis/kintlc') diff --git a/keyboards/kinesis/kintlc/config.h b/keyboards/kinesis/kintlc/config.h index 537cb399d8..d36555ce4a 100644 --- a/keyboards/kinesis/kintlc/config.h +++ b/keyboards/kinesis/kintlc/config.h @@ -78,17 +78,3 @@ // in clock cycles #define GPIO_INPUT_PIN_DELAY 0 - -// The default "1" results in LEDs being on when they should be off and -// the other way around. -#define LED_PIN_ON_STATE 0 - -// Discussion about which Teensy LC pins can be used for driving staus LEDs: -// https://github.com/kinx-project/kint/issues/55 -// Discussion about using Neopixel LEDs: -// https://github.com/kinx-project/kint/issues/32 -// Available pins can be seen in: -// /lib/chibios-contrib/os/hal/boards/PJRC_TEENSY_LC/board.h -#define LED_CAPS_LOCK_PIN LINE_PIN12 -#define LED_SCROLL_LOCK_PIN LINE_PIN25 -#define LED_COMPOSE_PIN LINE_PIN24 diff --git a/keyboards/kinesis/kintlc/info.json b/keyboards/kinesis/kintlc/info.json index d05b01ec09..7309fc778f 100644 --- a/keyboards/kinesis/kintlc/info.json +++ b/keyboards/kinesis/kintlc/info.json @@ -6,6 +6,12 @@ "pid": "0x345C", "device_version": "0.0.1" }, + "indicators": { + "caps_lock": "LINE_PIN12", + "scroll_lock": "LINE_PIN25", + "compose": "LINE_PIN24", + "on_state": 0 + }, "processor": "MKL26Z64", "bootloader": "halfkay", "debounce": 20 -- cgit v1.2.3 From 2da0827d4ffbcba161126d6001f370e97d0172a8 Mon Sep 17 00:00:00 2001 From: Ryan Date: Fri, 17 Feb 2023 16:08:25 +1100 Subject: Remove matrix size defines (#19581) --- keyboards/kinesis/kintlc/config.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'keyboards/kinesis/kintlc') diff --git a/keyboards/kinesis/kintlc/config.h b/keyboards/kinesis/kintlc/config.h index d36555ce4a..1939ac4e57 100644 --- a/keyboards/kinesis/kintlc/config.h +++ b/keyboards/kinesis/kintlc/config.h @@ -16,10 +16,6 @@ #pragma once -/* key matrix size */ -#define MATRIX_ROWS 15 -#define MATRIX_COLS 7 - /* * Keyboard Matrix Assignments * -- cgit v1.2.3